Add implementation_deps to _FRAMEWORK_PROVIDERS_ASPECT_ATTRS
#2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
keith
approved these changes
Aug 1, 2024
This allows the various framework rules to work correctly with the new-ish `implementation_deps` attribute of `objc_library`. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/add-implementation_deps-to-_framework_providers_aspect_attrs
branch
from
02b0b7f
to
9193684
Compare
luispadron
approved these changes
Aug 1, 2024
brentleyjones
force-pushed
the
bj/add-implementation_deps-to-_framework_providers_aspect_attrs
branch
from
39101c1
to
6f7da6b
Compare
brentleyjones
deleted the
bj/add-implementation_deps-to-_framework_providers_aspect_attrs
branch
sewerynplazuk
pushed a commit
to sewerynplazuk/rules_apple
that referenced
this pull request
Sep 20, 2024
…elbuild#2508) This allows the various framework rules to work correctly with the new-ish `implementation_deps` attribute of `objc_library`. Signed-off-by: Brentley Jones <github@brentleyjones.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the various framework rules to work correctly with the new-ish
implementation_depsattribute ofobjc_library.