Replace usages of to_json() with json.encode(..) #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struct.to_json() is deprecated and is being removed. This replaces usages of it with the builtin json module.
c-mita
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
|
Thanks @c-mita! |
brentleyjones
approved these changes
Mar 19, 2024
|
Can we make a new release to unblock migrating other projects? bazelbuild/rules_rust#2580 |
https://github.com/bazelbuild/rules_apple/releases/tag/3.4.0 has been cut and pushed to BCR, @meteorcloudy |
acecilia
pushed a commit
to revolut-mobile/rules_apple
that referenced
this pull request
Apr 12, 2024
struct.to_json() is deprecated and is being removed. This replaces usages of it with the builtin json module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
struct.to_json() is deprecated and is being removed.
This replaces usages of it with the builtin json module.