Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apple_common.Objc provider linking #1872

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

keith
Copy link
Member

@keith keith commented Feb 28, 2023

This involves:

  • Remove objc_provider input to new_executable_binary_provider
  • remove link info objc_provider input to framework providers
  • stop emitting ObjcProvider for purpose of linking info

PiperOrigin-RevId: 512999312
(cherry picked from commit 1d7c1a1)

@keith
Copy link
Member Author

keith commented Feb 28, 2023

can't merge until we want to drop bazel 6.x

keith referenced this pull request Feb 28, 2023
…he Apple linking logic in Bazel gets everything from CcInfo

This involves:
- Remove objc_provider input to new_executable_binary_provider
- remove link info objc_provider input to framework providers
- stop emitting ObjcProvider for purpose of linking info

PiperOrigin-RevId: 512999312
@keith keith force-pushed the ks/remove-apple_common.objc-provider-linking branch from 2802920 to 28dc8d1 Compare July 18, 2023 00:06
This involves:
- Remove objc_provider input to new_executable_binary_provider
- remove link info objc_provider input to framework providers
- stop emitting ObjcProvider for purpose of linking info

PiperOrigin-RevId: 512999312
(cherry picked from commit 1d7c1a1)
@keith keith force-pushed the ks/remove-apple_common.objc-provider-linking branch from 28dc8d1 to 5c223fb Compare August 17, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants