Use apple_platforms_split_transition for static_framework rules #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
referenced
this pull request
Aug 5, 2022
This change addresses removal of workaround introduced on <unknown commit> to map apple_common.multi_arch_split split attribute keys based on Bazel Apple static library linking API for iOS and tvOS static framework rules. - Removes `_apple_common_multi_arch_split_key` from transition_support lib. - Use `cc_toolchain_forwarder` for `_child_configuration_dummy` attribute. - Use rule descriptor `deps_cfg` for j2objc and Bazel's binary linking API attributes. - Introduce a new rule base transition that propagates `apple_platforms`. PiperOrigin-RevId: 461995942
brentleyjones
approved these changes
Aug 5, 2022
This change addresses removal of workaround introduced on <unknown commit> to map apple_common.multi_arch_split split attribute keys based on Bazel Apple static library linking API for iOS and tvOS static framework rules. - Removes `_apple_common_multi_arch_split_key` from transition_support lib. - Use `cc_toolchain_forwarder` for `_child_configuration_dummy` attribute. - Use rule descriptor `deps_cfg` for j2objc and Bazel's binary linking API attributes. - Introduce a new rule base transition that propagates `apple_platforms`. PiperOrigin-RevId: 461995942 (cherry picked from commit 15a38a1)
keith
force-pushed
the
ks/use-apple_platforms_split_transition-for-ios-tvos_static_framework-rules
branch
from
485627c
to
6d01765
Compare
keith
changed the title
keith
requested review from
BalestraPatrick,
segiddins,
thii and
mattrobmattrob
as code owners
keith
deleted the
ks/use-apple_platforms_split_transition-for-ios-tvos_static_framework-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses removal of workaround introduced on
to map apple_common.multi_arch_split split attribute keys based on Bazel
Apple static library linking API for iOS and tvOS static framework rules.
_apple_common_multi_arch_split_keyfrom transition_support lib.cc_toolchain_forwarderfor_child_configuration_dummyattribute.deps_cfgfor j2objc and Bazel's binary linking API attributes.apple_platforms.(cherry picked from commit 15a38a1)