-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _lcov_merger attribute to test rules #1388
Conversation
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/444 (must be Lyft employee to view) |
As of bazel 5.1 this can be used as a late bound attribute bazelbuild/bazel@14d8be0 This alleviates the concerns from #691 and allows users to use this feature, and avoid having to pass `LCOV_MERGER` in the environment manually
7749a20
to
91ebb94
Compare
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/486 (must be Lyft employee to view) |
Lyft integration job started: https://buildkite.com/lyft/rules-apple/builds/633 (must be Lyft employee to view) |
I would cut one more release before merging this, but then I think it's 👍 |
Do we need a new release first even? since it's in bazel 5.1+? I think of us supporting LTS meaning the newest in the LTS release version |
My thoughts are:
It doesn't directly impact me, since I think anyone on 5.x should be on 5.2 right now, but that was my reasoning at least. |
ok since we've done a release since then we can probably merge this one now? |
We now set the related attribute instead #1388
We now set the related attribute instead #1388
As of bazel 5.1 this can be used as a late bound attribute bazelbuild/bazel@14d8be0
This alleviates the concerns from
#691 and allows users to
use this feature, and avoid having to pass
LCOV_MERGER
in theenvironment manually