Skip to content

Commit

Permalink
Ensure signing actions are not cached nor sandboxed
Browse files Browse the repository at this point in the history
Because of multiple signing identities, depending on who is building,
the signature will be different, thus not cacheable.

Also, the "security" tools, which is used to parse the mobileprovision
file, doesn't play well with sandboxing.

Signed-off-by: Steeve Morin <steeve@zen.ly>
  • Loading branch information
steeve committed May 15, 2019
1 parent 5b03711 commit 2cf5a92
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions apple/internal/processor.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,14 @@ def _bundle_partial_outputs_files(
mnemonic = "BundleTreeApp",
progress_message = "Bundling, processing and signing %s" % ctx.label.name,
tools = bundling_tools,
execution_requirements = {
# Added so that the output of this action is not cached remotely, in case multiple
# developers sign the same artifact with different identities.
"no-cache": "1",
# Unsure, but may be needed for keychain access, especially for files that live in
# $HOME.
"no-sandbox": "1",
},
**action_args
)
else:
Expand Down

0 comments on commit 2cf5a92

Please sign in to comment.