Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github release flow #78

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Conversation

ted-xie
Copy link
Collaborator

@ted-xie ted-xie commented Jul 22, 2024

  • Properly set release test command
  • Correctly generate WORKSPACE stub in release_prep.sh
  • Adjust example WORKSPACE stub to make example WORKSPACE generation more straightforward.
  • Make release_prep.sh executable

Github workflow-based releases working properly in my fork: https://github.com/ted-xie/rules_android_ndk/releases/tag/v0.1.7

ted-xie added 2 commits July 22, 2024 14:03
* Properly set release test command
* Correctly generate WORKSPACE stub in release_prep.sh
* Adjust example WORKSPACE stub to make example WORKSPACE generation
  more straightforward.
* Make release_prep.sh executable
@ted-xie ted-xie requested a review from ahumesky July 22, 2024 18:12
@ted-xie ted-xie merged commit 461e8c9 into bazelbuild:main Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants