Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy_info gobinary visibility breaks builds when defining a custom android toolchain #209

Open
Bencodes opened this issue Feb 28, 2024 · 0 comments

Comments

@Bencodes
Copy link
Contributor

The go binary that was introduced as part of this commit aeb70ea#diff-04ca49b91bef564e399d9f954024ca9562661adc03742a55be6206dddb5fc53bR9 does not have the correct visibility that allows others to define custom toolchains outside rules_android.

Repro:

android_toolchain(
    name = "custom_android_toolchain",
    // ... pass custom args here
    visibility = ["//visibility:public"],
)

toolchain(
    name = "custom_android_default_toolchain",
    toolchain = ":custom_android_toolchain",
    toolchain_type = "@rules_android//toolchains/android:toolchain_type",
    visibility = ["//visibility:public"],
)
(12:40:33) ERROR: /Users/blee/Projects/instant-android/BUILD.bazel:24:18: in android_toolchain rule //:custom_android_toolchain: Visibility error:
target '@@rules_android//src/tools/deploy_info:deploy_info' is not visible from
target '//:custom_android_toolchain'
Recommendation: modify the visibility declaration if you think the dependency is legitimate. For more info see https://bazel.build/concepts/visibility
Bencodes added a commit to Bencodes/rules_android that referenced this issue Feb 28, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Mar 4, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Mar 4, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Mar 5, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Mar 5, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Mar 14, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Mar 26, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Apr 19, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Apr 23, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Jun 6, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Jun 6, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Jun 20, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Jun 21, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Jun 25, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Jul 9, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Jul 11, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Jul 16, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Jul 29, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Jul 31, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Aug 2, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Aug 5, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Aug 8, 2024
Bencodes added a commit to Bencodes/rules_android that referenced this issue Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant