ExecuteActionMetadata requires digest_function #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specified ExecuteActionMetadata will have no association with the digest_function requested in an execution, and cannot be used to retrieve the action, without a digest_function associated with it.
werkt
force-pushed
the
eam-digest-function
branch
from
c26335b to
00598d0
Compare
bergsieker
approved these changes
Sep 24, 2024
EdSchouten
added a commit
to buildbarn/bb-remote-execution
that referenced
this pull request
Sep 24, 2024
This field just got added to the protocol in the following PR: bazelbuild/remote-apis#311 For us it's trivial to expose this information, as we already have it stored in the Remote Worker desired state message. There it is guaranteed to be set, even for the traditional digest functions that don't require it.
EdSchouten
added a commit
to EdSchouten/remote-apis
that referenced
this pull request
Sep 24, 2024
- Unlike the other messages where a digest_function field was added, ExecuteActionMetadata is returned by the server to the client. This means that the words "client" and "server" need to be swapped around in some but not all places. - To ensure backward compatibility, we permit digest functions that were defined at the time this field was added to remain unset. When the digest_function fields were added to the other messages, the last one to be added was MURMUR3. In the meantime we've added BLAKE3 and SHA256TREE, so for this specific field we must list those as well.
EdSchouten
added a commit
to EdSchouten/remote-apis
that referenced
this pull request
Sep 24, 2024
- Unlike the other messages where a digest_function field was added, ExecuteActionMetadata is returned by the server to the client. This means that the words "client" and "server" need to be swapped around in some but not all places. - To ensure backward compatibility, we permit digest functions that were defined at the time this field was added to remain unset. When the digest_function fields were added to the other messages, the last one to be added was MURMUR3. In the meantime we've added BLAKE3 and SHA256TREE, so for this specific field we must list those as well.
EdSchouten
added a commit
to buildbarn/bb-remote-execution
that referenced
this pull request
Sep 24, 2024
This field just got added to the protocol in the following PR: bazelbuild/remote-apis#311 For us it's trivial to expose this information, as we already have it stored in the Remote Worker desired state message. There it is guaranteed to be set, even for the traditional digest functions that don't require it.
EdSchouten
added a commit
that referenced
this pull request
Sep 26, 2024
- Unlike the other messages where a digest_function field was added, ExecuteActionMetadata is returned by the server to the client. This means that the words "client" and "server" need to be swapped around in some but not all places. - To ensure backward compatibility, we permit digest functions that were defined at the time this field was added to remain unset. When the digest_function fields were added to the other messages, the last one to be added was MURMUR3. In the meantime we've added BLAKE3 and SHA256TREE, so for this specific field we must list those as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specified ExecuteActionMetadata will have no association with the digest_function requested in an execution, and cannot be used to retrieve the action, without a digest_function associated with it.