Handle file-based repositories. #66
Conversation
|
Can one of the admins verify this patch? |
| HttpURLConnection connection = (HttpURLConnection) new URL(sha1Url).openConnection(); | ||
| connection.setInstanceFollowRedirects(true); | ||
| URLConnection connection = new URL(sha1Url).openConnection(); | ||
| if (connection instanceof HttpURLConnection) { |
There was a problem hiding this comment.
Thank you again.
In the situation that it is not an HttpURLConnection, it would be a JarURLConnection. I doubt this should occur, so can you throw an exception?
Additionally, can you separate the sha functionality into a separate class, and add a simple test case for when this URLConnection fails?
Resolver.java has gotten fairly bloated, and I am trying to steer it so that Resolver.java has less functionality backed in. (see VersionResolver.java as an example)
There was a problem hiding this comment.
The connection can be an instance of any type that the URLStreamHandler for the protocol returns. For a file, this appears to be sun.net.www.protocol.file.FileURLConnection (at least on the JRE I'm using).
Both the sha and pom files will have the protocol file if the repository has a file URL.
This adds support for repositories in the local file system.
Fixes #64 .