Implement ModelResolver.addRepository(Repository, boolean) correctly.

[jkinkead]

This correctly honors the replace parameter. It was ignored before, which was making it effectively be treated as false.

Per the reference implementation, the single-argument addRepository should not replace (although it wasn't before).

[bazel-io]

Can one of the admins verify this patch?

[petroseskinder]

Thank you. The addRepositories(Repository repository, boolean replace) is never called, so we skimped out on including the replace functionality.

Assuming it's not particularly annoying, can you add a simple test case?

There isn't any DefaultModelResolverTest so you would need to create one, and mock the repositories.

[jkinkead]

Done.

I also updated the repository store, since the previous implementation was relying on the internal implementation of Repository.equals, which is not documented as operating only on ID (even though it appears to be).

[petroseskinder]

Good catch on the equals.

[petroseskinder]

Thank you. It looks good overall, barring a few nits.

[petroseskinder]

nit: can you add a simple comment for the boolean logic?
Although the new version is more concise, it took me a
second to remember the conditions.

[petroseskinder]

👍 to this change

[petroseskinder]

First thank you for the tests. One nit

Since each test is effectively doing the same thing, can you create the following utility functions

private Repository createRepository(String id, String url) {
     Repository repo = new Repository();
     repo.setId(id);
     repo.setUrl(url);
}

private void assertThatContainsRepo(
      DefaultModelResolver resolver, Repository repo) {...} 

private void assertThatUrlNotChanged(
       DefaultModelResolver resolver, Repository repo, String expectedUrl) {...}