Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for v2024.12.03 release #7183

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

ujohnny
Copy link
Collaborator

@ujohnny ujohnny commented Dec 17, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

Copy link

google-cla bot commented Dec 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Dec 17, 2024
…azelbuild#7139)

The old sync view does not use a pty based terminal and cannot handle bazel output correctly when it runs with curses.

(cherry picked from commit 0fb3f81)
Bazel is still run using a PtyCommandLine and seems to automatically enable curses when using the old sync view.

(cherry picked from commit 2bea8d9)
…iters and can be chunked not per line. (bazelbuild#7146)

(cherry picked from commit f5f8f24)
@ujohnny ujohnny force-pushed the enovozhilov/bugfix-v2024.12.03 branch from 6c1a3a5 to c207432 Compare December 17, 2024 12:33
@ujohnny
Copy link
Collaborator Author

ujohnny commented Dec 17, 2024

had to perform author reset to address CLA checks on github-hidden emails (would not like to put correct author emails there as anyway commits are signed by me).

@mai93 mai93 merged commit 79243fd into bazelbuild:v2024.12.03 Dec 17, 2024
5 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

2 participants