Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qsync): Hightlighting level is always updated after 'enable analy… #7101

Merged

Conversation

tpasternak
Copy link
Contributor

…sis'

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Dec 3, 2024
@sellophane sellophane self-requested a review December 3, 2024 18:01
@sellophane sellophane merged commit ea9092a into bazelbuild:master Dec 3, 2024
7 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Dec 3, 2024
@tpasternak tpasternak deleted the fix-hihglighting-level-not-updated branch December 3, 2024 18:05
@LeFrosch
Copy link
Collaborator

LeFrosch commented Dec 4, 2024

Just installed plugin from master, getting lots of these:

com.intellij.openapi.diagnostic.RuntimeExceptionWithAttachments: Read access is allowed from inside read-action only (see Application.runReadAction()); If you access or modify model on EDT consider wrapping your code in WriteIntentReadAction  or ReadAction; see https://jb.gg/ij-platform-threading for details
Current thread: Thread[#113,BlazeExecutor,4,main] 613902271 (EventQueue.isDispatchThread()=false)
SystemEventQueueThread: Thread[#66,AWT-EventQueue-0,6,main] 1870111808
	at com.intellij.util.concurrency.ThreadingAssertions.createThreadAccessException(ThreadingAssertions.java:218)
	at com.intellij.util.concurrency.ThreadingAssertions.softAssertReadAccess(ThreadingAssertions.java:155)
	at com.intellij.psi.impl.file.impl.FileManagerImpl.findFile(FileManagerImpl.java:375)
	at com.intellij.psi.impl.PsiManagerImpl.findFile(PsiManagerImpl.java:163)
	at com.google.idea.blaze.base.qsync.QuerySyncHighlightingResetListener.onNewProjectSnapshot(QuerySyncHighlightingResetListener.java:24)

@tpasternak
Copy link
Contributor Author

#7110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

5 participants