Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2024.11.05 hotfix #7053

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Conversation

tpasternak
Copy link
Contributor

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

Copy link

google-cla bot commented Nov 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tpasternak tpasternak changed the base branch from master to v2024.11.05 November 25, 2024 17:43
LeFrosch and others added 6 commits November 25, 2024 18:51
…d#6987)

Removed the check for GENERIC language class when determining if Java is enabled. This change ensures that only the presence of JAVA language class sets the "isJavaEnabled" flag to true.
…ld#7006)

Previously, the condition to load rules_java was based on the "additional languages" field,
which led to issues as Java is always present in IntelliJ (unlike PyCharm).
This change modifies the condition to explicitly check if rules_java
is actually loaded in the project, ensuring proper handling of non-Java projects in IntelliJ.
…zelbuild#7048)

* fix issues with aspect templates not available in query sync mode

* revise based on review
@tpasternak
Copy link
Contributor Author

tpasternak commented Nov 25, 2024

Manual test checklist:

  • Import with_numpy example with bazel8 rc2
  • import a bazel7 project with java_binary, but without rules_java loaded in MODULE.bazel
  • import a query sync project and try if java_binary can be run

@tpasternak tpasternak marked this pull request as ready for review November 25, 2024 18:02
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Nov 25, 2024
@mai93 mai93 merged commit 3c6e732 into bazelbuild:v2024.11.05 Nov 25, 2024
5 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Nov 25, 2024
@tpasternak tpasternak deleted the v2024.11.05-hotfix branch November 25, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

5 participants