-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2024.11.05 hotfix #7053
Merged
Merged
V2024.11.05 hotfix #7053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tpasternak
force-pushed
the
v2024.11.05-hotfix
branch
from
November 25, 2024 17:48
c973def
to
5fe0e15
Compare
…d#6987) Removed the check for GENERIC language class when determining if Java is enabled. This change ensures that only the presence of JAVA language class sets the "isJavaEnabled" flag to true.
…ld#7006) Previously, the condition to load rules_java was based on the "additional languages" field, which led to issues as Java is always present in IntelliJ (unlike PyCharm). This change modifies the condition to explicitly check if rules_java is actually loaded in the project, ensuring proper handling of non-Java projects in IntelliJ.
…zelbuild#7048) * fix issues with aspect templates not available in query sync mode * revise based on review
tpasternak
force-pushed
the
v2024.11.05-hotfix
branch
from
November 25, 2024 17:52
5fe0e15
to
7c8901e
Compare
Manual test checklist:
|
github-actions
bot
added
product: CLion
CLion plugin
product: IntelliJ
IntelliJ plugin
product: GoLand
GoLand plugin
awaiting-review
Awaiting review from Bazel team on PRs
labels
Nov 25, 2024
github-actions
bot
removed
the
awaiting-review
Awaiting review from Bazel team on PRs
label
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>
Description of this change