show squiggly line when import class not in build target #473

idankWix · 2018-12-18T09:45:49Z

No description provided.

googlebot · 2018-12-18T09:45:53Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

base/src/com/google/idea/blaze/base/sync/BlazeSyncTask.java

idankWix · 2018-12-18T10:02:41Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).

The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.

The email used to register you as an authorized contributor must also be attached to your GitHub account.

I signed it!

googlebot · 2018-12-18T10:02:43Z

CLAs look good, thanks!

idankWix · 2018-12-18T10:04:30Z

or-shachar

waiting for @hmemcpy for technical insights. Looks good. I had minor comments about google style... and a question about intellij event system.

base/src/com/google/idea/blaze/base/ui/problems/BlazeProblemsView.java

or-shachar · 2018-12-18T10:04:23Z

base/src/com/google/idea/blaze/base/run/BlazeBeforeRunCommandHelper.java

@@ -65,7 +67,7 @@ private BlazeBeforeRunCommandHelper() {}
        (BlazeCommandRunConfigurationCommonState) configuration.getHandler().getState();
    WorkspaceRoot workspaceRoot = WorkspaceRoot.fromProject(project);
    ProjectViewSet projectViewSet = ProjectViewManager.getInstance(project).getProjectViewSet();
-
+      ServiceManager.getService(ImportProblemContainerService.class).resetIssues();


@hmemcpy - is there an event system in Intellij such that instead of triggering an action here, we can broadcast an event that will cause other processes to be triggered?

ittaiz · 2018-12-21T19:02:38Z

@brendandouglas wdyt?

base/src/com/google/idea/blaze/base/lang/buildfile/actions/BuildFileModifierImpl.java

or-shachar · 2018-12-27T08:40:29Z

base/src/com/google/idea/blaze/base/lang/buildfile/actions/BuildFileModifierImpl.java

+    private void addTargetToDepsIfNeeded(Argument.Keyword depsKeyword, Label targetToBeAdded, Project project) {
+        PsiElement depsElement = depsKeyword.getPsiChild(BuildElementTypes.LIST_LITERAL, null);
+        if(depsDoesntHaveWhiteSpace(depsElement)){
+            addWhiteSpaceElement(project, depsElement, "\n    ");


Can we use https://github.com/bazelbuild/intellij/blob/master/base/src/com/google/idea/blaze/base/buildmodifier/BuildFileFormatter.java for final formatting?

idankWix · 2019-01-08T13:05:07Z

@brendandouglas can you pls go over the PR ?

brendandouglas · 2019-01-08T21:44:50Z

base/BUILD

@@ -19,6 +19,7 @@ java_library(
        "//sdkcompat",
        "//third_party/auto_value",
        "@error_prone_annotations//jar",
+        "//third_party/scala",


The 'base' module is used across all IDEs, and can't have a language specific dep (unless that language is supported in all JetBrains IDEs).

fixed by moving to async messaging

brendandouglas · 2019-01-08T21:44:59Z

Thanks for the pull request. I haven't had a chance to look over it yet, but will try to get to it within the next day or two.

brendandouglas · 2019-01-08T22:12:16Z

base/src/com/google/idea/blaze/base/ui/problems/ImportIssueResolver.java

+    private static final String NEW_LINE = "\n";
+    private static String missingImportRegEx = "object .* is not a member of package .*";
+    private static String wildCardOrStaticRegEx = "package .* does not exist";
+    private static String javaStaticImport = "static import only from classes and interfaces";


Shouldn't problems like this already be annotated in the IDE?

they are not currently

brendandouglas · 2019-01-08T22:13:45Z

Thanks again for the PR. I think the general approach of annotating missing imports/deps and providing a quick-fix action is good. Ideally, we wouldn't need to run a bazel build to find these.

We have a separate system for this internally. Bazel outputs a error with a suggested fix such as "Command to add missing dependencies: '[command line script]'". We add a hyperlink to the bazel console view (also linked in the bazel problems view) to run the script and apply the fix.

Otherwise, I'm not sure when we'd be able to work on this PR, since there's a fair bit of work involved applying it upstream. Some examples: I'd prefer to use buildozer directly rather than manually modifying BUILD files, the language-specific bits need to be moved to the appropriate modules, we'd need to add some tests and documentation, and make some style changes.

or-shachar · 2019-01-14T16:32:13Z

@brendandouglas - how do we proceed on this?

Ideally, we wouldn't need to run a bazel build to find these.

What are the alternatives?

We have a separate system for this internally.

Great! but we need to enrich this public plugin as well.. And this is our contribution to make it better and complete. Can you elaborate on the tool? is it something Wix can use?

Otherwise, I'm not sure when we'd be able to work on this PR, since there's a fair bit of work involved
applying it upstream.

I'm a bit confused by this. What does it mean?

I'd prefer to use buildozer directly rather than manually modifying BUILD files, the language-specific
bits need to be moved to the appropriate modules

See my suggestions here: #477 - would love to hear your comment . If you need our contribution here - we can do it.

we'd need to add some tests and documentation, and make some style changes.

What is the style guide? Where can we add documentation?

===
Bottom line - From the belief in bazel as a build tool and Intellij as our IDE, and from an Open Source approach - we are willing to work hard and contribute but we need your hand in this.

Would really like to know what are the concrete steps you want to do in order to push this plugin forward.

Thanks!
cc: @ittaiz

brendandouglas · 2019-01-16T17:40:17Z

@or-shachar, our preferred way of implementing this kind of feature would be via 'add_deps' support at bazel build time (there's some discussion of this in bazelbuild/bazel/issues/4846 and bazelbuild/bazel/issues/4584).

That moves responsibility for determining the appropriate fix to the build, rather than having a separate layer in the IDE. If that was implemented in bazel, we'd simply parse the relevant command in bazel's stdout/stderr, and add an entry to the 'bazel problems' view, as well as adding a link to the console output.

Otherwise, I'm not sure when we'd be able to work on this PR, since there's a fair bit of work involved
applying it upstream.

I'm a bit confused by this. What does it mean?

This github project is just a mirror of our internal project. Applying patches involves:

rewriting the PR to conform to our coding practices, style guide, etc.
adding appropriate unit and integration tests and safeguards to lessen the chance of internal regressions, especially related to performance.

All of this takes time, so we prefer to iron out the details of a potential contribution beforehand, to save effort (see the 'contributions' section of the top level readme).

…d-action only

…d-action only + no line fix

sgowroji · 2022-09-01T08:34:16Z

Hello @idankWix , If you are still looking to submit the above PR for review. Could you please resolve the code conflicts and fix the build checks. I can help you in arranging the review. Thanks!

keertk · 2022-12-07T19:34:40Z

Hi there! Thank you for contributing to the IntelliJ repository. We appreciate your time and effort. We're doing a clean up of old PRs and will be closing this one since it seems to have stalled. Please feel free to reopen/let us know if you’re still interested in pursuing this or if you'd like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

or-shachar reviewed Dec 18, 2018

View reviewed changes

base/src/com/google/idea/blaze/base/sync/BlazeSyncTask.java Outdated Show resolved Hide resolved

or-shachar reviewed Dec 18, 2018

View reviewed changes

or-shachar reviewed Dec 27, 2018

View reviewed changes

base/src/com/google/idea/blaze/base/lang/buildfile/actions/BuildFileModifierImpl.java Show resolved Hide resolved

or-shachar reviewed Dec 27, 2018

View reviewed changes

brendandouglas reviewed Jan 8, 2019

View reviewed changes

idankWix added 14 commits January 23, 2019 11:25

show squiggly line when import class not in build target

85dffa7

add quick fix - phase 1 - handle import without wildcard and alias

9ec9ed6

add quick fix - phase 1 - handle import without wildcard and alias

a27190e

revert import wildcards

57ca411

add quick fix - phase 1 - handle import without wildcard and alias

edacff7

fix new line

bd08663

fix wildcard import dependency missing for java files

145c479

dependency fix by package

dd62828

dependency fix for multiple scala import

1c9ace7

formatting the build file

090da4e

formatting the build file - rewritting the way target is added

9a35724

Scala recursive walk for wildcard imports

369f485

Fix unsupported import exception

10ead7d

support scala aliases

883a73a

idankWix added 14 commits January 23, 2019 11:25

support scala aliases

0c389b5

support scala aliases

d9951e0

Fix null pointer exception

8770fd7

fix regex for multi and alias

e2b1b51

fix nullpointer when parent not exist

a50f221

TABS VS SPACES - spaces win tabs break manual editing

03be54f

support java static import

298e5e3

fix nullpointer

0737157

reset import issues when compiling project

98427ca

FIX - read access is allowed from event dispatch thread or inside rea…

925590a

…d-action only

FIX - read access is allowed from event dispatch thread or inside rea…

2709f76

…d-action only + no line fix

recursive search for target (aggregated targets)

ddc9f44

move to pub sub impl

5b0522a

move to pub sub impl

827d098

idankWix force-pushed the same-repo-import-issue-resolver branch from caa3f04 to 827d098 Compare January 23, 2019 09:27

idankWix added 3 commits January 23, 2019 12:19

remove hidden files

2f18b93

remove hidden files

2290474

use buildozer if possible to update build files

73c8546

sgowroji added the awaiting-user-response Awaiting response from author on PRs label Sep 1, 2022

bazelbuild deleted a comment from sgowroji Dec 7, 2022

keertk closed this Dec 7, 2022

jastice removed the awaiting-user-response Awaiting response from author on PRs label Jan 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

show squiggly line when import class not in build target #473

show squiggly line when import class not in build target #473

idankWix commented Dec 18, 2018

googlebot commented Dec 18, 2018

idankWix commented Dec 18, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Dec 18, 2018

idankWix commented Dec 18, 2018

or-shachar left a comment

or-shachar Dec 18, 2018

ittaiz commented Dec 21, 2018

or-shachar Dec 27, 2018

idankWix Jan 8, 2019

idankWix commented Jan 8, 2019

brendandouglas Jan 8, 2019

idankWix Jan 20, 2019

brendandouglas commented Jan 8, 2019

brendandouglas Jan 8, 2019

idankWix Jan 9, 2019

brendandouglas commented Jan 8, 2019

or-shachar commented Jan 14, 2019 •

edited

Loading

brendandouglas commented Jan 16, 2019

sgowroji commented Sep 1, 2022

keertk commented Dec 7, 2022

show squiggly line when import class not in build target #473

show squiggly line when import class not in build target #473

Conversation

idankWix commented Dec 18, 2018

googlebot commented Dec 18, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

idankWix commented Dec 18, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Dec 18, 2018

idankWix commented Dec 18, 2018

or-shachar left a comment

Choose a reason for hiding this comment

or-shachar Dec 18, 2018

Choose a reason for hiding this comment

ittaiz commented Dec 21, 2018

or-shachar Dec 27, 2018

Choose a reason for hiding this comment

idankWix Jan 8, 2019

Choose a reason for hiding this comment

idankWix commented Jan 8, 2019

brendandouglas Jan 8, 2019

Choose a reason for hiding this comment

idankWix Jan 20, 2019

Choose a reason for hiding this comment

brendandouglas commented Jan 8, 2019

brendandouglas Jan 8, 2019

Choose a reason for hiding this comment

idankWix Jan 9, 2019

Choose a reason for hiding this comment

brendandouglas commented Jan 8, 2019

or-shachar commented Jan 14, 2019 • edited Loading

brendandouglas commented Jan 16, 2019

sgowroji commented Sep 1, 2022

keertk commented Dec 7, 2022

or-shachar commented Jan 14, 2019 •

edited

Loading