Removing a check for infix expression element from specs2 test configuration creation #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Ok, this probably relates to the bug #168, relating to the finding of existing configurations. There's a check in |
|
@chaoren could you please take a look at this? |
chaoren
reviewed
Nov 29, 2017
| private static String getElementStaticText(PsiElement element) { | ||
| return TestConfigurationUtil.getStaticTestNameOrDefault( | ||
| element, | ||
| null, |
There was a problem hiding this comment.
Ugh, they named the parameter "default". I think it's messing up the IDE.
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh wow, so that's why the red squiggly :(
I upvoted the issue, let's hope it will be fixed before flying cars :)
|
Merged internally, now to export to github. |
|
Thanks!
…On Thu, 30 Nov 2017 at 19:17 Chaoren Lin ***@***.***> wrote:
Merged internally, now to export to github.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#167 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABUIFwLwYnZ3tYH8NzH15N8tvcGlKj7Cks5s7uM-gaJpZM4QrUVg>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
Fixes #168
This pull request removes the check for
ScInfixExprfrom the test configuration for scala2 (see #155). This fixes a bug that prevents right-clicking and running the individual tests.This is caused due to the element which is right-clicked will usually be the
Literalidentifier (i.e. "the test name"). An additional lookup for the parentScInfixExpris needed to get the actual test case element. This PR adds this lookup.In addition, some APIs were tweaked to reduce the dependance on the Scala types.