Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCR PR reviewer: add support for a "do_not_notify" field #2037

Merged
merged 2 commits into from
Sep 18, 2024
Merged

BCR PR reviewer: add support for a "do_not_notify" field #2037

merged 2 commits into from
Sep 18, 2024

Commits on Sep 17, 2024

  1. BCR PR reviewer: add support for a "doNotNotify" field 

    A maintainer can request to not be notified by new PRs by setting  `"doNotNotify": true`. In this case, they can still approve the PR and have it count, but they won't be pinged.

This helps in situations like protobuf's release rotation, which has a lot of people but ideally only the releaser should be notified and be able to approve the PR. It's rather hard to support a "rotating" maintainer model, though. Thus we compromise by adding everyone from that rotation as a "do-not-notify" maintainer, and asking the releaser to watch out for the PR manually as a release step.
    @Wyverald
    Wyverald authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d0a648c View commit details
    Browse the repository at this point in the history

  2. "doNotNotify" -> "do_not_notify" 

    metadata.json already has the field "yanked_versions" using lower snake case, so I updated this field to follow suit.
    @Wyverald
    Wyverald authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0a6d4b2 View commit details
    Browse the repository at this point in the history