Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verification job for gerrit@RBE #1072

Closed
davido opened this issue Dec 15, 2020 · 3 comments
Closed

Add verification job for gerrit@RBE #1072

davido opened this issue Dec 15, 2020 · 3 comments

Comments

@davido
Copy link
Contributor

davido commented Dec 15, 2020

It would be great to extend gerrit verification job to run also on RBE (like Bazel itself).

Something like this works for me:

  $ bazel test --config=remote --remote_instance_name=<project-name> javatests/...

This would help detect Bazel RBE regressions, e.g.: bazelbuild/bazel#12705.
@davido
Copy link
Contributor Author

davido commented Nov 14, 2023

@meteorcloudy

What would need to be done to enable Gerrit verification on RBE?
Or downstream project shouldn't be tested on RBE?

@meteorcloudy
Copy link
Member

meteorcloudy commented Nov 14, 2023 •
edited
Loading

Change the platform name from ubuntu2004 to rbe_ubuntu2004 would probably do.

But it's a bit hard to test it since the config file is in CI repo: https://github.com/bazelbuild/continuous-integration/blob/master/pipelines/gerrit.yml#L3C3-L3C13

I think it'll be helpful if the Gerrit repo can host this config file.

davido added a commit to davido/continuous-integration that referenced this issue Nov 18, 2023
@davido
Add additional platforms: RBE and fedora39
b52e3b8 
Closes bazelbuild#1072.
davido added a commit to davido/continuous-integration that referenced this issue Nov 22, 2023
@davido
Add additional platforms to gerrit pipelines: RBE and fedora39
812e3fe 
Closes bazelbuild#1072.

We have seen multiple breakages on RBE platforms and modern C++
toolchains. To prevent potential breakages and/or to detect them
earlier we are adding those new platforms to the gerrit pipeline.
davido added a commit to davido/continuous-integration that referenced this issue Nov 22, 2023
@davido
Add additional platforms to gerrit pipelines: RBE and fedora39
b4f910e 
Closes bazelbuild#1072.

We have seen multiple breakages on RBE platforms and modern C++
toolchains. To prevent potential breakages and/or to detect them
earlier we are adding those new platforms to the gerrit pipeline.
@meteorcloudy
Copy link
Member

Done in #1829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davido @meteorcloudy