Verifying the hash of downloaded Bazel binary #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting Don't create tempfile more strict about sha256 file Python 2 compatibility Improve error message
|
@philwo Would you mind also taking a look at this? |
|
@fweikert Would you mind taking a look at this too? |
fweikert
requested changes
Mar 3, 2022
fweikert
approved these changes
Mar 4, 2022
gcf-merge-on-green bot
referenced
this pull request
in googleapis/gapic-generator-typescript
Jul 22, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@bazel/bazelisk](https://togithub.com/bazelbuild/bazelisk) | [`^1.11.0` -> `^1.12.0`](https://renovatebot.com/diffs/npm/@bazel%2fbazelisk/1.11.0/1.12.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bazelbuild/bazelisk</summary> ### [`v1.12.0`](https://togithub.com/bazelbuild/bazelisk/releases/tag/v1.12.0) [Compare Source](https://togithub.com/bazelbuild/bazelisk/compare/v1.11.0...v1.12.0) This release brings new features and fixes to both versions of Bazelisk: Go: - Added support for basic HTTP authentication via a .netrc file ([https://github.com/bazelbuild/bazelisk/pull/292](https://togithub.com/bazelbuild/bazelisk/pull/292)) - Improved and fixed Apple Silicon support ([https://github.com/bazelbuild/bazelisk/pull/299](https://togithub.com/bazelbuild/bazelisk/pull/299), [https://github.com/bazelbuild/bazelisk/pull/303](https://togithub.com/bazelbuild/bazelisk/pull/303)) - Rolling releases are now fetched from GCS instead of GitHub ([https://github.com/bazelbuild/bazelisk/pull/319](https://togithub.com/bazelbuild/bazelisk/pull/319)) Python: - Added support for Apple Silicon ([https://github.com/bazelbuild/bazelisk/pull/272](https://togithub.com/bazelbuild/bazelisk/pull/272)) - Implemented verification of downloaded Bazel binaries ([https://github.com/bazelbuild/bazelisk/pull/295](https://togithub.com/bazelbuild/bazelisk/pull/295)) We'd like to thank our contributors [@​chenrui333](https://togithub.com/chenrui333), [@​codeman9](https://togithub.com/codeman9), [@​cpsauer](https://togithub.com/cpsauer), [@​keith](https://togithub.com/keith), [@​linzhp](https://togithub.com/linzhp), [@​Warchant](https://togithub.com/Warchant) and [@​xinnjie](https://togithub.com/xinnjie)! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-typescript). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMjIuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEyMi4xIn0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some areas with unstable or slow internet, the downloaded Bazel may be corrupted. We should verify the hash of the downloaded binary, delete the binary and prompt users to try again if it is corrupted. For backward compatibility for existing mirrors that don't have sha256 file, we will skip the verification if the ".sha256" file doesn't exist.