Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong warning message on M1 Mac when setting USE_BAZEL_VERSION=last_green #391

Closed
meteorcloudy opened this issue Oct 24, 2022 · 0 comments · Fixed by #392
Closed

Wrong warning message on M1 Mac when setting USE_BAZEL_VERSION=last_green #391

meteorcloudy opened this issue Oct 24, 2022 · 0 comments · Fixed by #392
Assignees
@fweikert

Comments

@meteorcloudy
Copy link
Member 

pcloudy@pcloudy-macbookpro2:~/workspace/bazel-central-registry (test_change)
$ export USE_BAZEL_VERSION=last_green
pcloudy@pcloudy-macbookpro2:~/workspace/bazel-central-registry (test_change)
$ bazelisk
2022/10/24 12:06:54 WARN: Fallback to x86_64 because arm64 is not supported on Apple Silicon until 4.1.0
2022/10/24 12:06:54 Using unreleased version at commit 3d2bb2a400c48bc51e43db11ac154d999a97881b
2022/10/24 12:06:54 Downloading https://storage.googleapis.com/bazel-builds/artifacts/macos_arm64/3d2bb2a400c48bc51e43db11ac154d999a97881b/bazel...
WARNING: Invoking Bazel in batch mode since it is not invoked from within a workspace (below a directory having a WORKSPACE file).
Extracting Bazel installation...

It complains Fallback to x86_64 because arm64 is not supported on Apple Silicon until 4.1.0 but in fact did downloaded the arm64 binary for the last green commit.
@fweikert fweikert assigned fweikert and unassigned fweikert Oct 24, 2022
fweikert added a commit to fweikert/bazelisk that referenced this issue Oct 24, 2022
@fweikert
Suppress Apple Silicon fallback warning for commits.
9b2315e 
Bazelisk on M1 always printed "Fallback to x86_64 because arm64 is not supported on Apple Silicon until 4.1.0" when asking for a Bazel binary built at a commit.
However, the code downloaded the ARM64 binary regardless (which was the correct behavior given that commits are very likely newer than Bazel 4.1).

This commit suppresses the warning message in this case.

Fixes bazelbuild#391
@fweikert fweikert self-assigned this Oct 24, 2022
fweikert pushed a commit to fweikert/bazelisk that referenced this issue Oct 24, 2022
@meteorcloudy @fweikert
This is the commit message #2:
eb7cde2 
Suppress Apple Silicon fallback warning for commits.

Bazelisk on M1 always printed "Fallback to x86_64 because arm64 is not supported on Apple Silicon until 4.1.0" when asking for a Bazel binary built at a commit.
However, the code downloaded the ARM64 binary regardless (which was the correct behavior given that commits are very likely newer than Bazel 4.1).

This commit suppresses the warning message in this case.

Fixes bazelbuild#391
fweikert pushed a commit to fweikert/bazelisk that referenced this issue Oct 24, 2022
@meteorcloudy @fweikert
Suppress Apple Silicon fallback warning for commits.
dbf8806 
Bazelisk on M1 always printed "Fallback to x86_64 because arm64 is not supported on Apple Silicon until 4.1.0" when asking for a Bazel binary built at a commit.
However, the code downloaded the ARM64 binary regardless (which was the correct behavior given that commits are very likely newer than Bazel 4.1).

This commit suppresses the warning message in this case.

Fixes bazelbuild#391
@fweikert fweikert mentioned this issue Oct 24, 2022
Merged
fweikert added a commit that referenced this issue Oct 24, 2022
@fweikert
Suppress Apple Silicon fallback warning for commits. (#392)
d1565d8 
Bazelisk on M1 always printed "Fallback to x86_64 because arm64 is not supported on Apple Silicon until 4.1.0" when asking for a Bazel binary built at a commit.
However, the code downloaded the ARM64 binary regardless (which was the correct behavior given that commits are very likely newer than Bazel 4.1).

This commit suppresses the warning message in this case.

Fixes #391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fweikert fweikert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suppress Apple Silicon fallback warning for commits. fweikert/bazelisk
2 participants
@meteorcloudy @fweikert