Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows, *_binary launcher: bazel-bin/x.EXE works #9400

Closed
wants to merge 2 commits into from
Closed

Windows, *_binary launcher: bazel-bin/x.EXE works #9400

wants to merge 2 commits into from

Conversation

laszlocsomor
Copy link
Contributor

Fixes #9390

@laszlocsomor laszlocsomor requested a review from philwo September 18, 2019 12:04
@bazel-io bazel-io closed this in c7bc414 Sep 18, 2019
@laszlocsomor laszlocsomor deleted the gh9390 branch September 18, 2019 14:51
@aherrmann
Copy link
Contributor

@dslomov would it be possible to cherry-pick this fix into 1.0? We would like to depend on this fix in rules_haskell.

@laszlocsomor
Copy link
Contributor Author

@aherrmann : Sorry, 1.0 was released without this fix, but 1.1 will have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philwo philwo Awaiting requested review from philwo

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sh_binary wrapper fails on upper case letters in file extension on Windows
3 participants
@laszlocsomor @aherrmann @googlebot