fewer words, easier reading #9326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, can you double-check? I don't see the expected changes |
gnarled-cipher
force-pushed
the
fixing_grammar
branch
from
7ec597a
to
4a714a3
Compare
|
My bad! changes are now in. Thank you! |
laurentlb
reviewed
Sep 4, 2019
site/docs/skylark/language.md
Outdated
| @@ -105,10 +105,9 @@ illegal, and 2) `*args` and `**kwargs` arguments are not allowed. | |||
| * Global variables are immutable. | |||
|
|
|||
| * `for` statements are not allowed at the top-level. Use them within functions | |||
| instead. In BUILD files, you may use list comprehensions. | |||
| instead. In BUILD files, you may use list comprehensions. That said, we prefer that you use macros, because we think they are easier to read. | |||
There was a problem hiding this comment.
I'd remove this line (I know it was suggested by @brandjon).
We also want to limit the use of macros.
There was a problem hiding this comment.
I removed it. Thank you!
incorporating feedback incorporating feedback applying fixes applying fixes
gnarled-cipher
force-pushed
the
fixing_grammar
branch
from
4a714a3
to
a5f63b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporating feedback from PR 9310.