Windows: fix "bazel run" argument quoting #9123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two axes of variables: - server mode vs. batch mode (--[no]batch) - Windows only: Bash-less vs. Bash-ful bazel run (--[no]incompatible_windows_bashless_run_command) To "bazel run" a target, Bazel first builds the target then creates a run request. The request is a protobuf that contains the command line (argv) and environment (envvars, cwd). In server mode (--nobatch), the Bazel server sends the run request to the client, and the client executes the program (with CreateProcessW on Windows / execv on Unixes). In batch mode (--batch), the Bazel server itself executes the program using ProcessBuilder. In Bash-ful bazel run mode the run request is for "bash -c <program> <args>...", while in Bash-less more it is for "<program> <args>...". The argument escaping must be different in both cases, because bash.exe uses Bash-style quoting/escaping while most native Windows programs use the MSVC style. Fixes the issue mentioned in bazelbuild#8240 (comment)
laszlocsomor
changed the title
meteorcloudy
approved these changes
Aug 8, 2019
katre
pushed a commit
that referenced
this pull request
Aug 12, 2019
There are two axes of variables: - server mode vs. batch mode (--[no]batch) - Windows only: Bash-less vs. Bash-ful bazel run (--[no]incompatible_windows_bashless_run_command) To "bazel run" a target, Bazel first builds the target then creates a run request. The request is a protobuf that contains the command line (argv) and environment (envvars, cwd). In server mode (--nobatch), the Bazel server sends the run request to the client, and the client executes the program (with CreateProcessW on Windows / execv on Unixes). In batch mode (--batch), the Bazel server itself executes the program using ProcessBuilder. In Bash-ful bazel run mode the run request is for "bash -c <program> <args>...", while in Bash-less more it is for "<program> <args>...". The argument escaping must be different in both cases, because bash.exe uses Bash-style quoting/escaping while most native Windows programs use the MSVC style. Fixes #9106 Fixes #9108 Closes #9123. PiperOrigin-RevId: 262519795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two axes of variables:
(--[no]incompatible_windows_bashless_run_command)
To "bazel run" a target, Bazel first builds the
target then creates a run request. The request is
a protobuf that contains the command line (argv)
and environment (envvars, cwd).
In server mode (--nobatch), the Bazel server sends
the run request to the client, and the client
executes the program (with CreateProcessW on
Windows / execv on Unixes). In batch mode
(--batch), the Bazel server itself executes the
program using ProcessBuilder.
In Bash-ful bazel run mode the run request is for
"bash -c ...", while in Bash-less
more it is for " ...". The argument
escaping must be different in both cases, because
bash.exe uses Bash-style quoting/escaping while
most native Windows programs use the MSVC style.
Fixes #9106