-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit naming convention to style guide for rules #8884
Conversation
Thank you for sending this. I'm pretty much in agreement with this PR and the team has informally been following this convention. That said, it probably should be opened for other people to comment. Can you post a link to the bazel-dev list to start that discussion. |
adding @philwo for section about CI. |
I started a change to import this to the main repo. To me, we either adopt this rule OR we are saying that qualified names should be the rule, and we start renaming the world. I don't see that happening, so let's just codify the most common practice. |
repository `<org>_rules_<lang>` (e.g. `build_stack_rules_proto`). Please contact | ||
[bazel-dev mailing list](https://groups.google.com/forum/#!forum/bazel-dev) | ||
if you feel like your rules should follow the convention for rules in the | ||
[bazelbuild](https://github.com/bazelbuild) organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that the name is an implementation detail of a repository (ideally, they shouldn't rely on it). So I'd rather not have users send us an email for this.
Maybe just remove this sentence?
No description provided.