Fix GenClass target label in java_tool's java_toolchain #8490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aehlig |
iirina
pushed a commit
to iirina/bazel
that referenced
this pull request
Jun 4, 2019
Fixes bazelbuild/intellij#845 This causes IntelliJ resolution to fail when there's a `java_plugin` in the build. The filegroup is `GenClass`, not `Genclass`. ``` filegroup( name = "GenClass", srcs = ["java_tools/GenClass_deploy.jar"], ) ``` This will require a new java_tools release and a patch release to 0.26.0. Closes bazelbuild#8490. PiperOrigin-RevId: 250487423
iirina
pushed a commit
to iirina/bazel
that referenced
this pull request
Jun 4, 2019
Fixes bazelbuild/intellij#845 This causes IntelliJ resolution to fail when there's a `java_plugin` in the build. The filegroup is `GenClass`, not `Genclass`. ``` filegroup( name = "GenClass", srcs = ["java_tools/GenClass_deploy.jar"], ) ``` This will require a new java_tools release and a patch release to 0.26.0. Closes bazelbuild#8490. PiperOrigin-RevId: 250487423
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
Fixes bazelbuild/intellij#845 This causes IntelliJ resolution to fail when there's a `java_plugin` in the build. The filegroup is `GenClass`, not `Genclass`. ``` filegroup( name = "GenClass", srcs = ["java_tools/GenClass_deploy.jar"], ) ``` This will require a new java_tools release and a patch release to 0.26.0. Closes bazelbuild#8490. PiperOrigin-RevId: 250487423
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
Fixes bazelbuild/intellij#845 This causes IntelliJ resolution to fail when there's a `java_plugin` in the build. The filegroup is `GenClass`, not `Genclass`. ``` filegroup( name = "GenClass", srcs = ["java_tools/GenClass_deploy.jar"], ) ``` This will require a new java_tools release and a patch release to 0.26.0. Closes bazelbuild#8490. PiperOrigin-RevId: 250487423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bazelbuild/intellij#845
This causes IntelliJ resolution to fail when there's a
java_pluginin the build.The filegroup is
GenClass, notGenclass.This will require a new java_tools release and a patch release to 0.26.0.