remote: grpcs (grpc+tls) is used by default for remote URLs #8456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cheme prefix RELNOTES: --remote_executor, --remote_cache or --bes_backend=someurl.com would be treated as grpcs://someurl.com, if the --incompatible_tls_enabled_removed flag enabled. See bazelbuild#8061 for details.
buchgr
reviewed
May 24, 2019
| @@ -91,6 +91,10 @@ private static boolean isTlsEnabled(String target, AuthAndTLSOptions options) { | |||
| if (options.incompatibleTlsEnabledRemoved && options.tlsEnabled) { | |||
| throw new IllegalArgumentException("flag --tls_enabled was not found"); | |||
| } | |||
| if (options.incompatibleTlsEnabledRemoved) { | |||
| // 'grpcs://' or empty prefix => TLS-enabled | |||
There was a problem hiding this comment.
Maybe expand the comment on empty prefix a bit?
|
That's great! Thanks! |
|
LGTM |
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
RELNOTES: --remote_executor, --remote_cache or --bes_backend=someurl.com would be treated as grpcs://someurl.com, if the --incompatible_tls_enabled_removed flag enabled. See bazelbuild#8061 for details. Closes bazelbuild#8456. PiperOrigin-RevId: 251199122
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
RELNOTES: --remote_executor, --remote_cache or --bes_backend=someurl.com would be treated as grpcs://someurl.com, if the --incompatible_tls_enabled_removed flag enabled. See bazelbuild#8061 for details. Closes bazelbuild#8456. PiperOrigin-RevId: 251199122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELNOTES: --remote_executor, --remote_cache or --bes_backend=someurl.com would be treated as grpcs://someurl.com, if the --incompatible_tls_enabled_removed flag enabled. See #8061 for details.