Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checker_framework_annotations to third_party #8212

Closed
wants to merge 3 commits into from
Closed

Add checker_framework_annotations to third_party #8212

wants to merge 3 commits into from

Conversation

justinhorvitz
Copy link
Contributor

Allows us to annotate and type-check code

@justinhorvitz justinhorvitz requested a review from janakdr April 30, 2019 19:57
@janakdr janakdr requested a review from katre April 30, 2019 20:04
katre
katre approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@katre katre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will handle merging this.

@katre
Copy link
Member

katre commented Apr 30, 2019

Squashed and merged in 255d35c.

@katre katre closed this Apr 30, 2019
bazel-io pushed a commit that referenced this pull request May 1, 2019
@copybara-github
Type-check tests for @GroupedList.Compressed.
baefeab 
Each test enforces that all objects referenced by @GroupedList.Compressed in the package originate from one of the annotated static methods in GroupedList.

To be submitted after #8212.

PiperOrigin-RevId: 246052739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katre katre katre approved these changes

@janakdr janakdr janakdr approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinhorvitz @katre @janakdr @googlebot