Remove third_party/checker_* from the binary. #8163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binaries were there because there Java tooling needed it (until it
was moved to its own separate repository) and the sources were there for
GPL compliance (which is not the case anymore since we don't distribute
the binaries, either)
To be extra safe on the GPL compliance side, I checked with 'bazel query
"rdeps(//...,//third_party/checker_framework_{javacutil,dataflow})"'
whether we have any dependencies on it that might end up being
distributed; turns out, the only dependencies are JavaBuilder (which is
not distributed with Bazel anymore) and some tests.
meisterT
approved these changes
Apr 26, 2019
|
/cc @cushon |
iirina
reviewed
Apr 26, 2019
third_party/BUILD
Outdated
| @@ -26,8 +26,6 @@ filegroup( | |||
| "//third_party/java/jdk/langtools:srcs", | |||
| "//third_party/java/proguard:srcs", | |||
| "//third_party/javascript/bootstrap:srcs", | |||
| "//third_party/checker_framework_dataflow:srcs", | |||
There was a problem hiding this comment.
The targets of third_party:srcs are not all embedded into the bazel binary. IIUC this target is to keep track of the sources in the bazel repo, so I would keep them here.
There was a problem hiding this comment.
Done -- I removed it just so that rdeps gives a cleaner answer.
| @@ -50,8 +48,6 @@ filegroup( | |||
| filegroup( | |||
| name = "gpl-srcs", | |||
| srcs = [ | |||
| "//third_party/checker_framework_dataflow:srcs", | |||
There was a problem hiding this comment.
Since you started this, can you also add them to the java tools dist archive? It's defined by src:java_tools_dist_java*
|
All done! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binaries were there because there Java tooling needed it (until it
was moved to its own separate repository) and the sources were there for
GPL compliance (which is not the case anymore since we don't distribute
the binaries, either)
To be extra safe on the GPL compliance side, I checked with
whether we have any dependencies on it that might end up being
distributed; turns out, the only dependencies are JavaBuilder (which is
not distributed with Bazel anymore, as proven by the above query) and some tests.