Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .h++ extension for header files #8112

Closed
wants to merge 2 commits into from

Conversation

macbutch
Copy link
Contributor

This fixes #8111 (which I just opened).

Let me know if changes are needed. I have essentially followed what I saw in 77ac48e (which fixes #302 which is a similar issue affecting source files with .c++ extension).

@macbutch macbutch requested a review from lberki as a code owner April 23, 2019 07:03
@aiuto aiuto added the team-Rules-CPP Issues for C++ rules label Apr 24, 2019
@macbutch macbutch requested a review from hlopko as a code owner June 6, 2019 09:14
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlopko
Copy link
Member

hlopko commented Jun 13, 2019

Was this PR imported?

@hlopko hlopko removed request for hlopko and lberki June 13, 2019 10:05
@hlopko hlopko assigned oquenchil and unassigned hlopko Jun 13, 2019
@bazel-io bazel-io closed this in ed86ef2 Jun 17, 2019
irengrig pushed a commit to irengrig/bazel that referenced this pull request Jun 18, 2019
This fixes bazelbuild#8111 (which I just opened).

Let me know if changes are needed. I have essentially followed what I saw in 77ac48e (which fixes bazelbuild#302 which is a similar issue affecting source files with `.c++` extension).

Closes bazelbuild#8112.

PiperOrigin-RevId: 253532672
siberex pushed a commit to siberex/bazel that referenced this pull request Jul 4, 2019
This fixes bazelbuild#8111 (which I just opened).

Let me know if changes are needed. I have essentially followed what I saw in 77ac48e (which fixes bazelbuild#302 which is a similar issue affecting source files with `.c++` extension).

Closes bazelbuild#8112.

PiperOrigin-RevId: 253532672
irengrig pushed a commit to irengrig/bazel that referenced this pull request Jul 15, 2019
This fixes bazelbuild#8111 (which I just opened).

Let me know if changes are needed. I have essentially followed what I saw in 77ac48e (which fixes bazelbuild#302 which is a similar issue affecting source files with `.c++` extension).

Closes bazelbuild#8112.

PiperOrigin-RevId: 253532672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept .h++ as an extension for C++ headers Accept .c++ as an extension for cc_library / cc_binary srcs
5 participants