Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort DirectoryNode children to ensure validity. #8008

Closed
wants to merge 1 commit into from

Conversation

werkt
Copy link
Contributor

@werkt werkt commented Apr 11, 2019

InputTree will create DirectoryNodes with non-sequential additions of
directory children. These must be maintained in order for representation
within remote Directory messages (and to properly compute action keys).

InputTree will create DirectoryNodes with non-sequential additions of
directory children. These must be maintained in order for representation
within remote Directory messages (and to properly compute action keys).
@bazel-io bazel-io closed this in 4299b65 Apr 12, 2019
@werkt werkt deleted the directory-sorted-children branch April 12, 2019 22:59
dkelmer pushed a commit that referenced this pull request Apr 16, 2019
InputTree will create DirectoryNodes with non-sequential additions of
directory children. These must be maintained in order for representation
within remote Directory messages (and to properly compute action keys).

Co-Author=buchgr

Closes #8008.

PiperOrigin-RevId: 243235156
dkelmer pushed a commit that referenced this pull request Apr 25, 2019
InputTree will create DirectoryNodes with non-sequential additions of
directory children. These must be maintained in order for representation
within remote Directory messages (and to properly compute action keys).

Co-Author=buchgr

Closes #8008.

PiperOrigin-RevId: 243235156
dkelmer pushed a commit that referenced this pull request Apr 25, 2019
InputTree will create DirectoryNodes with non-sequential additions of
directory children. These must be maintained in order for representation
within remote Directory messages (and to properly compute action keys).

Co-Author=buchgr

Closes #8008.

PiperOrigin-RevId: 243235156
dkelmer pushed a commit that referenced this pull request Apr 25, 2019
InputTree will create DirectoryNodes with non-sequential additions of
directory children. These must be maintained in order for representation
within remote Directory messages (and to properly compute action keys).

Co-Author=buchgr

Closes #8008.

PiperOrigin-RevId: 243235156
dkelmer pushed a commit that referenced this pull request Apr 26, 2019
InputTree will create DirectoryNodes with non-sequential additions of
directory children. These must be maintained in order for representation
within remote Directory messages (and to properly compute action keys).

Co-Author=buchgr

Closes #8008.

PiperOrigin-RevId: 243235156
dkelmer pushed a commit that referenced this pull request Apr 29, 2019
InputTree will create DirectoryNodes with non-sequential additions of
directory children. These must be maintained in order for representation
within remote Directory messages (and to properly compute action keys).

Co-Author=buchgr

Closes #8008.

PiperOrigin-RevId: 243235156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants