Flip --incompatible_windows_escape_jvm_flags #7646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: bazelbuild#7486 RELNOTES[INC]: Flip --incompatible_windows_escape_jvm_flags to true. See bazelbuild#7486
laszlocsomor
changed the title
|
Flipping this flag has to wait until it's in the latest release, but you can even test this flag before that. Just create a downstream test for this PR by following |
|
Great, thanks for the info! I'll do that! |
|
All downstream projects look green: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/843 This is suspicious. Do you think everything worked correctly? |
|
Bazel 0.24.x is released and has this flag (default: false). Running another presubmit with downstream tests before I flip this flag: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/903 |
|
All green. |
dkelmer
pushed a commit
that referenced
this pull request
Apr 11, 2019
All downstream projects are green: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/903 Fixes: #7486 RELNOTES[INC]: Flip --incompatible_windows_escape_jvm_flags to true. See #7486 Closes #7646. PiperOrigin-RevId: 242107771
dkelmer
pushed a commit
that referenced
this pull request
Apr 16, 2019
All downstream projects are green: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/903 Fixes: #7486 RELNOTES[INC]: Flip --incompatible_windows_escape_jvm_flags to true. See #7486 Closes #7646. PiperOrigin-RevId: 242107771
dkelmer
pushed a commit
that referenced
this pull request
Apr 25, 2019
All downstream projects are green: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/903 Fixes: #7486 RELNOTES[INC]: Flip --incompatible_windows_escape_jvm_flags to true. See #7486 Closes #7646. PiperOrigin-RevId: 242107771
dkelmer
pushed a commit
that referenced
this pull request
Apr 25, 2019
All downstream projects are green: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/903 Fixes: #7486 RELNOTES[INC]: Flip --incompatible_windows_escape_jvm_flags to true. See #7486 Closes #7646. PiperOrigin-RevId: 242107771
dkelmer
pushed a commit
that referenced
this pull request
Apr 25, 2019
All downstream projects are green: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/903 Fixes: #7486 RELNOTES[INC]: Flip --incompatible_windows_escape_jvm_flags to true. See #7486 Closes #7646. PiperOrigin-RevId: 242107771
dkelmer
pushed a commit
that referenced
this pull request
Apr 26, 2019
All downstream projects are green: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/903 Fixes: #7486 RELNOTES[INC]: Flip --incompatible_windows_escape_jvm_flags to true. See #7486 Closes #7646. PiperOrigin-RevId: 242107771
dkelmer
pushed a commit
that referenced
this pull request
Apr 29, 2019
All downstream projects are green: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/903 Fixes: #7486 RELNOTES[INC]: Flip --incompatible_windows_escape_jvm_flags to true. See #7486 Closes #7646. PiperOrigin-RevId: 242107771
philwo
added
the
team-OSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7486
RELNOTES[INC]: Flip --incompatible_windows_escape_jvm_flags to true. See #7486