Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wunused-command-line-argument warnings when --force_pic is passed on Mac #6478

Closed
wants to merge 1 commit into from
Closed

Fix -Wunused-command-line-argument warnings when --force_pic is passed on Mac #6478

wants to merge 1 commit into from

Conversation

jamiesnape
Copy link

For clang on macOS, there is no -pie command line argument, so you need -Wl,-pie to pass the flag to the linker and avoid the following warning:

INFO: From Linking <executable>:
clang: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument]

@lberki lberki requested review from hlopko and removed request for lberki October 24, 2018 08:14
@jamiesnape
Copy link
Author

Resolved merge conflicts. Can this at least be approved for presubmit testing even if review is delayed?

@aiuto aiuto added the z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple label Oct 29, 2018
@lberki
Copy link
Contributor

lberki commented Nov 12, 2018

Sorry for the late reply!

@oquenchil , what do you think? It's a bit more special-casing, but it doesn't make the situation much worse... I'd say go ahead.

@hlopko
Copy link
Member

hlopko commented Nov 19, 2018

LGTM, thanks! I'll import this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants