Update protobuf to 3.6.1 -- update references #6068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR completes steps 7..9 in https://github.com/bazelbuild/bazel/blob/9ed9d8ac4347408d15c8fce7c9c07e5c8e658b30/third_party/protobuf/README.md See bazelbuild#6061 Change-Id: I38b5c00f80da3203d7bd6eb10bb29d9bf13bb79e
laszlocsomor
force-pushed
the
update-proto-2
branch
from
b705709
to
69999d6
Compare
See protocolbuffers/protobuf#5085 Change-Id: I1253bd78388f14bac78e01841cfcdb6b72c8860b
|
/cc @scentini |
laurentlb
approved these changes
Sep 4, 2018
third_party/protobuf/3.6.1/BUILD
Outdated
| @@ -91,9 +91,11 @@ COPTS = select({ | |||
| ], | |||
| }) | |||
|
|
|||
| config_setting( | |||
| load(":compiler_config_setting.bzl", "create_compiler_config_setting") | |||
There was a problem hiding this comment.
please put load() statements at the top of the file
Change-Id: I9d89d4afcf0ca0efa0ba46414666708b1bffad85
Change-Id: Ia5e315a9ce07da5b518df7d9a28a42817bf4ce22
|
Closed by 27303d7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes steps 7..9 in
https://github.com/bazelbuild/bazel/blob/9ed9d8ac4347408d15c8fce7c9c07e5c8e658b30/third_party/protobuf/README.md
See #6061
Change-Id: I38b5c00f80da3203d7bd6eb10bb29d9bf13bb79e