Make the embedded JDK targets the default #5403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laszlocsomor
suggested changes
Jun 15, 2018
src/BUILD
Outdated
| @@ -38,8 +38,8 @@ filegroup( | |||
| "//conditions:default": md5_cmd % "md5sum", | |||
| }), | |||
| ) for suffix, embedded_tools_target in { | |||
| "": [":embedded_tools"], | |||
| "_with_jdk": [":embedded_tools_with_jdk"], | |||
| "": [":embedded_tools_nojdk"], | |||
There was a problem hiding this comment.
did you mean "embedded_tools" here, and "embedded_tools_nojdk" below?
cushon
force-pushed
the
nojdk
branch
2 times, most recently
from
1ccf7a2
to
a58362b
Compare
ArielleA
pushed a commit
to ArielleA/bazel
that referenced
this pull request
Jun 19, 2018
Closes bazelbuild#5403. PiperOrigin-RevId: 201007405
werkt
pushed a commit
to werkt/bazel
that referenced
this pull request
Aug 2, 2018
Closes bazelbuild#5403. PiperOrigin-RevId: 201007405
werkt
pushed a commit
to werkt/bazel
that referenced
this pull request
Oct 19, 2018
Closes bazelbuild#5403. PiperOrigin-RevId: 201007405
meisterT
added a commit
to meisterT/bazel
that referenced
this pull request
Dec 13, 2018
RELNOTES: None
bazel-io
pushed a commit
that referenced
this pull request
Dec 13, 2018
RELNOTES: None Closes #6915. PiperOrigin-RevId: 225373869
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.