python,runfiles: move to different package #4981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the Python runfiles library from @bazel_tools//tools/runfiles:py-runfiles to @bazel_tools//tools/python/runfiles:runfiles Fixes bazelbuild#4878 Change-Id: I874b230c93679d4454ac91e816932c8272ecc5c7
Change-Id: I908e0ab7ec61225e82f70793b1a05432e7f0b07e
|
ping @lberki |
|
Looks good! Sorry for the delay -- I accidentally marked the e-mail read thinking it's a code review to be done by you sent by someone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the Python runfiles library from
@bazel_tools//tools/runfiles:py-runfilesto@bazel_tools//tools/python/runfiles:runfilesAlso rename the testdata runfiles.py to foo.py.
This file was not a mock runfiles library, just a
client file using the runfiles library that was
also called runfiles.py
Fixes #4878
Change-Id: I874b230c93679d4454ac91e816932c8272ecc5c7