runfiles,Python: remove library from @bazel_tools #4879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily remove the Python runfiles library from @bazel_tools and so prevent releasing it in Bazel 0.12.0. Motivation: bazelbuild#4878 Fixing that bug *after* the python library is in release Bazel would be harder because users would need to update their code and BUILD files. Fixing that bug before the library is released is a lot easier because nobody depends on it yet, and we can release the library when it's in the right place. Change-Id: I8adc219410571f9e2a4c8060f5b3239b957fbd5f
dslomov
approved these changes
Mar 20, 2018
philwo
pushed a commit
that referenced
this pull request
Mar 21, 2018
Temporarily remove the Python runfiles library from @bazel_tools and so prevent releasing it in Bazel 0.12.0. Motivation: #4878 Fixing that bug *after* the python library is in release Bazel would be harder because users would need to update their code and BUILD files. Fixing that bug before the library is released is a lot easier because nobody depends on it yet, and we can release the library when it's in the right place. Closes #4879. Change-Id: I8adc219410571f9e2a4c8060f5b3239b957fbd5f PiperOrigin-RevId: 189744985
philwo
pushed a commit
that referenced
this pull request
Apr 9, 2018
Temporarily remove the Python runfiles library from @bazel_tools and so prevent releasing it in Bazel 0.12.0. Motivation: #4878 Fixing that bug *after* the python library is in release Bazel would be harder because users would need to update their code and BUILD files. Fixing that bug before the library is released is a lot easier because nobody depends on it yet, and we can release the library when it's in the right place. Closes #4879. Change-Id: I8adc219410571f9e2a4c8060f5b3239b957fbd5f PiperOrigin-RevId: 189744985
philwo
pushed a commit
that referenced
this pull request
Apr 11, 2018
Temporarily remove the Python runfiles library from @bazel_tools and so prevent releasing it in Bazel 0.12.0. Motivation: #4878 Fixing that bug *after* the python library is in release Bazel would be harder because users would need to update their code and BUILD files. Fixing that bug before the library is released is a lot easier because nobody depends on it yet, and we can release the library when it's in the right place. Closes #4879. Change-Id: I8adc219410571f9e2a4c8060f5b3239b957fbd5f PiperOrigin-RevId: 189744985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily remove the Python runfiles library
from @bazel_tools and so prevent releasing it in
Bazel 0.12.0.
Motivation: #4878
Fixing that bug after the python library is in
release Bazel would be harder because users would
need to update their code and BUILD files.
Fixing that bug before the library is released is
a lot easier because nobody depends on it yet, and
we can release the library when it's in the right
place.