Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI configuration to run tests with Python 3 interpreter #3873

Closed
wants to merge 2 commits into from
Closed

Add CI configuration to run tests with Python 3 interpreter #3873

wants to merge 2 commits into from

Conversation

duggelz
Copy link

@duggelz duggelz commented Oct 6, 2017

Fixes #3872

@bazel-io
Copy link
Member

bazel-io commented Oct 6, 2017

Can one of the admins verify this patch?

@duggelz
Copy link
Author

duggelz commented Oct 6, 2017

@damienmg @mattmoor How do I poke the CI system to test this?

@mattmoor
Copy link

mattmoor commented Oct 6, 2017

test this please

@mattmoor
Copy link

mattmoor commented Oct 6, 2017

I guess I lack the magic powers on this repo.

@damienmg
Copy link
Contributor

damienmg commented Oct 6, 2017

@duggelz : you need to make the google org public on your github account to have the right to trigger a build. And then "test this please" is the magic sentence (it also auto build at each new push if the pr comes from you).

@duggelz
Copy link
Author

duggelz commented Oct 6, 2017

Huh, I had no idea they were private. Fixed. I wonder how much past confusion this has caused :(

test this please

@duggelz
Copy link
Author

duggelz commented Oct 6, 2017

test this please

Fiddling with permissions, currently getting this error:

Caused by: com.google.api.client.http.HttpResponseException: 400 Bad Request
{
  "error" : "invalid_grant",
  "error_description" : "Invalid JWT Signature."
}
	at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:1070)
	at com.google.auth.oauth2.ServiceAccountCredentials.refreshAccessToken(ServiceAccountCredentials.java:317)

@damienmg
Copy link
Contributor

damienmg commented Oct 7, 2017

Were do you get that error from?

@duggelz
Copy link
Author

duggelz commented Oct 7, 2017

Permission error is gone, now I'm seeing the Python 3 errors I expect to see:

http://ci.bazel.io/blue/rest/organizations/jenkins/pipelines/PR/pipelines/bazel-tests/runs/121/nodes/26/log/?start=0

Along with a FreeBSD error that seems completely unrelated:

http://ci.bazel.io/blue/rest/organizations/jenkins/pipelines/PR/pipelines/bazel-tests/runs/121/nodes/28/log/?start=0

Could you look at the config and Jenkins output and confirm that I am indeed running the tests under both Python 2 and Python 3? I.e. once without --python_path and once with --python_path? Because I look at the pretty graphic and I only see one node=linux-x86_64 under "Run Configurations", but I would sort of expect to see two.

Copy link
Contributor

@damienmg damienmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment for fixing the only one configuration issue.

@@ -4,6 +4,12 @@
{
"configurations": [
{"node": "linux-x86_64"},
{
"node": "linux-x86_64",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "python_version": "3"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@@ -4,6 +4,12 @@
{
"configurations": [
{"node": "linux-x86_64"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "python_version": "2"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

"parameters": {
"build_opts": ["--python_path=/usr/bin/python3"]
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend removing the non-linux configuration so you get a less noisy result. E.g. freebsd is a breakage at HEAD.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@duggelz
Copy link
Author

duggelz commented Dec 15, 2017

Can we submit this with failing tests, or do we have to fix all the Python 3 breakages first, then submit this?

@duggelz duggelz changed the title [WIP] Add CI configuration to run tests with Python 3 interpreter Add CI configuration to run tests with Python 3 interpreter Dec 15, 2017
"parameters": {
"python_version": "2",
},
{
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what indentation it wants here.

@duggelz
Copy link
Author

duggelz commented Dec 21, 2017

test this please

(For Bazel CI system)

@duggelz
Copy link
Author

duggelz commented Dec 21, 2017

Tests now pass, except for the FreeBSD node which is unrelatedly broken at HEAD, from what I can tell.

@bazel-io bazel-io closed this in b30dfcb Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants