-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI configuration to run tests with Python 3 interpreter #3873
Conversation
Can one of the admins verify this patch? |
test this please |
I guess I lack the magic powers on this repo. |
@duggelz : you need to make the google org public on your github account to have the right to trigger a build. And then "test this please" is the magic sentence (it also auto build at each new push if the pr comes from you). |
Huh, I had no idea they were private. Fixed. I wonder how much past confusion this has caused :( test this please |
test this please Fiddling with permissions, currently getting this error:
|
Were do you get that error from? |
Permission error is gone, now I'm seeing the Python 3 errors I expect to see: Along with a FreeBSD error that seems completely unrelated: Could you look at the config and Jenkins output and confirm that I am indeed running the tests under both Python 2 and Python 3? I.e. once without |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment for fixing the only one configuration issue.
scripts/ci/bazel-tests.json
Outdated
@@ -4,6 +4,12 @@ | |||
{ | |||
"configurations": [ | |||
{"node": "linux-x86_64"}, | |||
{ | |||
"node": "linux-x86_64", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "python_version": "3"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
scripts/ci/bazel-tests.json
Outdated
@@ -4,6 +4,12 @@ | |||
{ | |||
"configurations": [ | |||
{"node": "linux-x86_64"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "python_version": "2"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
scripts/ci/bazel-tests.json
Outdated
"parameters": { | ||
"build_opts": ["--python_path=/usr/bin/python3"] | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend removing the non-linux configuration so you get a less noisy result. E.g. freebsd is a breakage at HEAD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Can we submit this with failing tests, or do we have to fix all the Python 3 breakages first, then submit this? |
scripts/ci/bazel-tests.json
Outdated
"parameters": { | ||
"python_version": "2", | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what indentation it wants here.
test this please (For Bazel CI system) |
Tests now pass, except for the FreeBSD node which is unrelatedly broken at HEAD, from what I can tell. |
Fixes #3872