Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0] Propagate linkopts of header-only libraries to cc_shared_library #24002

Closed
wants to merge 1 commit into from

Conversation

bazel-io
Copy link
Member

Fixes #21884
Fixes #23053

Closes #23215.

PiperOrigin-RevId: 686518093
Change-Id: I1a6699b169fe4291ad0dda3be7e74f38c8e37bf1

Commit 0fdb36f

Fixes bazelbuild#21884
Fixes bazelbuild#23053

Closes bazelbuild#23215.

PiperOrigin-RevId: 686518093
Change-Id: I1a6699b169fe4291ad0dda3be7e74f38c8e37bf1
@bazel-io bazel-io requested a review from a team as a code owner October 16, 2024 15:49
@bazel-io bazel-io added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Oct 16, 2024
@bazel-io bazel-io requested a review from pzembrod October 16, 2024 15:49
@iancha1992 iancha1992 enabled auto-merge October 16, 2024 15:50
@iancha1992
Copy link
Member

@fmeum @pzembrod
Should we not let this merge and just close this? as per #24087?

cc: @bazelbuild/triage

@meteorcloudy
Copy link
Member

@fmeum Should we close this one for now?

@fmeum
Copy link
Collaborator

fmeum commented Oct 28, 2024

@meteorcloudy Yes, let's focus on fixing this at head.

@fmeum fmeum closed this Oct 28, 2024
auto-merge was automatically disabled October 28, 2024 09:46

Pull request was closed

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants