Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary copying in getDirectoryEntries implementations #23435

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Aug 27, 2024

File#list is documented to never return "." and "..".

`File#list` is documented to never return `"."` and `".."`.
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Aug 27, 2024
@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 27, 2024
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmeum
Copy link
Collaborator Author

fmeum commented Aug 27, 2024

@bazel-io fork 7.4.0

@satyanandak satyanandak added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Aug 28, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 28, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Aug 28, 2024
`File#list` is documented to never return `"."` and `".."`.

Closes bazelbuild#23435.

PiperOrigin-RevId: 668327754
Change-Id: I0beb70a82232990a83671485dcd97208ea4bd147
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
…tions (#23452)

`File#list` is documented to never return `"."` and `".."`.

Closes #23435.

PiperOrigin-RevId: 668327754
Change-Id: I0beb70a82232990a83671485dcd97208ea4bd147

Commit
bf2eff8

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@fmeum fmeum deleted the avoid-copy-list branch August 28, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants