Force use of Clang over C++ modules with use_module_maps
#22660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `-std=c++20`, Clang defaults to using C++ modules rather than Clang modules, which can result in failures when using `layering_check` and thus `use_module_maps`.
github-actions
bot
added
team-Rules-CPP
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
oquenchil
approved these changes
Jun 6, 2024
|
@oquenchil The flag unfortunately requires clang-14: llvm/llvm-project@0556138 I will add version detection logic. |
keith
approved these changes
Jun 6, 2024
|
@bazel-io fork 7.3.0 |
bazel-io
removed
the
potential release blocker
|
I added feature detection. |
oquenchil
approved these changes
Jun 7, 2024
oquenchil
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jun 12, 2024
With `-std=c++20`, Clang defaults to using C++ modules rather than Clang modules, which can result in failures when using `layering_check` and thus `use_module_maps`. Fixes bazel-contrib/toolchains_llvm#334 Closes bazelbuild#22660. PiperOrigin-RevId: 642548168 Change-Id: Ie1dd4c482d716635f7b6c53ffd3c5d84b6aa8cc2
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
…22720) With `-std=c++20`, Clang defaults to using C++ modules rather than Clang modules, which can result in failures when using `layering_check` and thus `use_module_maps`. Fixes bazel-contrib/toolchains_llvm#334 Closes #22660. PiperOrigin-RevId: 642548168 Change-Id: Ie1dd4c482d716635f7b6c53ffd3c5d84b6aa8cc2 Commit 9e913fb Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
|
The changes in this PR have been included in Bazel 7.3.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
-std=c++20, Clang defaults to using C++ modules rather than Clang modules, which can result in failures when usinglayering_checkand thususe_module_maps.Fixes bazel-contrib/toolchains_llvm#334