-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test][windows] Export BAZEL_TEST=1 on windows #21444
Conversation
This was an oversight from when exporting BAZEL_TEST on Linux. fixes: bazelbuild#21420
I searched on https://github.com/bazelbuild/bazel/blob/4e43b4aaa3a0f85a6390326e245c675c091c965b/tools/test/windows/tw_test.cc to see how could I test this, but those are not blackbox run a subprocess and see what env variables were actually sent type of tests. Maybe that test is somewhere but I couldn't find it. If you could point me to it, I could perhaps add the test? |
An oversight, test pass now
You could add an assertion to https://github.com/bazelbuild/bazel/blob/master/src/test/py/bazel/test_wrapper_test.py or a new test to https://github.com/bazelbuild/bazel/blob/master/src/test/py/bazel/bazel_windows_test.py. |
Sorry for the messy CLs, but I don't want to install Java (and the other toolchains that might be required) just for this, so I'm abusing the CI a bit to run the tests for me. |
The other approach wouldn't have worked.
Now we correctly query for the env variable
Okay I stopped being lazy and figured how to run the tests locally ( Sorry for the spam. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This was an oversight from when exporting BAZEL_TEST on Linux. fixes: bazelbuild#21420 Closes bazelbuild#21444. PiperOrigin-RevId: 610338496 Change-Id: Icbbdc42b6ea92a2de2b0c558aea47a24493c9d8a
This was an oversight from when exporting BAZEL_TEST on Linux.
fixes: #21420