Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose build event stream and starlark debugging protos #21196

Closed

Conversation

cameron-martin
Copy link
Contributor

This makes the build event stream and starlark debugging proto libraries public. This is for consumption by the vscode-bazel plugin, which already uses these but in a very hacky way.

Fixes #16335
Fixes #3684

This makes the build event stream and starlark debugging proto libraries public. This is for consumption by the vscode-bazel plugin, which already uses these but in a very hacky way.

Fixes bazelbuild#16335
Fixes bazelbuild#3684
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Feb 4, 2024
@sgowroji sgowroji added the team-Core Skyframe, bazel query, BEP, options parsing, bazelrc label Feb 5, 2024
@brentleyjones
Copy link
Contributor

@bazelbuild/triage Can we get someone to review this please? 🙏

@iancha1992
Copy link
Member

@bazelbuild/triage Can we get someone to review this please? 🙏

cc: @lberki @meteorcloudy @meisterT

@meteorcloudy
Copy link
Member

@comius Can you take a look at the proto usages in Bazel?

@comius comius added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 10, 2024
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 11, 2024
@meteorcloudy
Copy link
Member

@bazel-io fork 7.2.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 11, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Apr 11, 2024
This makes the build event stream and starlark debugging proto libraries public. This is for consumption by the vscode-bazel plugin, which already uses these but in a very hacky way.

Fixes bazelbuild#16335
Fixes bazelbuild#3684

Closes bazelbuild#21196.

PiperOrigin-RevId: 623740758
Change-Id: Ic47d6dd05fcf2af8beec4d9212d4c7fd65bcda44
github-merge-queue bot pushed a commit that referenced this pull request Apr 15, 2024
This makes the build event stream and starlark debugging proto libraries
public. This is for consumption by the vscode-bazel plugin, which
already uses these but in a very hacky way.

Fixes #16335
Fixes #3684

Closes #21196.

PiperOrigin-RevId: 623740758
Change-Id: Ic47d6dd05fcf2af8beec4d9212d4c7fd65bcda44

Commit
adfe016

Co-authored-by: Cameron Martin <cameronmartin123@gmail.com>
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 26, 2024
Kila2 pushed a commit to Kila2/bazel that referenced this pull request May 13, 2024
This makes the build event stream and starlark debugging proto libraries public. This is for consumption by the vscode-bazel plugin, which already uses these but in a very hacky way.

Fixes bazelbuild#16335
Fixes bazelbuild#3684

Closes bazelbuild#21196.

PiperOrigin-RevId: 623740758
Change-Id: Ic47d6dd05fcf2af8beec4d9212d4c7fd65bcda44
@cameron-martin cameron-martin deleted the expose-protos branch June 17, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use build_event_stream.proto as external dependency BuildEventProtocol is not publically visible
7 participants