-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose build event stream and starlark debugging protos #21196
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the build event stream and starlark debugging proto libraries public. This is for consumption by the vscode-bazel plugin, which already uses these but in a very hacky way. Fixes bazelbuild#16335 Fixes bazelbuild#3684
github-actions
bot
added
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Feb 4, 2024
5 tasks
@bazelbuild/triage Can we get someone to review this please? 🙏 |
|
@comius Can you take a look at the proto usages in Bazel? |
comius
approved these changes
Apr 10, 2024
comius
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Apr 10, 2024
@bazel-io flag |
bazel-io
added
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Apr 11, 2024
@bazel-io fork 7.2.0 |
bazel-io
removed
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Apr 11, 2024
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 11, 2024
This makes the build event stream and starlark debugging proto libraries public. This is for consumption by the vscode-bazel plugin, which already uses these but in a very hacky way. Fixes bazelbuild#16335 Fixes bazelbuild#3684 Closes bazelbuild#21196. PiperOrigin-RevId: 623740758 Change-Id: Ic47d6dd05fcf2af8beec4d9212d4c7fd65bcda44
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
This makes the build event stream and starlark debugging proto libraries public. This is for consumption by the vscode-bazel plugin, which already uses these but in a very hacky way. Fixes #16335 Fixes #3684 Closes #21196. PiperOrigin-RevId: 623740758 Change-Id: Ic47d6dd05fcf2af8beec4d9212d4c7fd65bcda44 Commit adfe016 Co-authored-by: Cameron Martin <cameronmartin123@gmail.com>
sgowroji
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Apr 26, 2024
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
This makes the build event stream and starlark debugging proto libraries public. This is for consumption by the vscode-bazel plugin, which already uses these but in a very hacky way. Fixes bazelbuild#16335 Fixes bazelbuild#3684 Closes bazelbuild#21196. PiperOrigin-RevId: 623740758 Change-Id: Ic47d6dd05fcf2af8beec4d9212d4c7fd65bcda44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the build event stream and starlark debugging proto libraries public. This is for consumption by the vscode-bazel plugin, which already uses these but in a very hacky way.
Fixes #16335
Fixes #3684