Allow @repo_name labels in override attributes
#21188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
apparent-name-patches
branch
from
ed32dfb to
23d844d
Compare
fmeum
changed the title
repo_name in override label strings@repo_name labels in override attributes
fmeum
force-pushed
the
apparent-name-patches
branch
from
0f43b5f to
a85852c
Compare
github-actions
bot
added
team-ExternalDeps
Wyverald
approved these changes
Feb 7, 2024
fmeum
force-pushed
the
apparent-name-patches
branch
from
a85852c to
c34db13
Compare
|
@Wyverald I resolved the conflict |
|
@bazel-io fork 7.1.0 |
Wyverald
added
awaiting-PR-merge
fmeum
force-pushed
the
apparent-name-patches
branch
from
c34db13 to
731d527
Compare
|
I resolved the conflict. |
github-actions
bot
removed
the
awaiting-PR-merge
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Feb 12, 2024
This is made possible by a refactoring that moves the label parsing of `RepoSpec` attributes coming from module overrides as well as `.bzl` file labels containing repo rules from `BzlmodRepoRuleFunction` into `ModuleFileGlobals`. Also adds a TODO to `BzlmodRepoRuleFunction` to further simplify the logic after the next lockfile version bumps, as old lockfiles are now the only source of non-canonical labels in `RepoSpec`s. Work towards bazelbuild#19301 Closes bazelbuild#21188. PiperOrigin-RevId: 605517195 Change-Id: Id34c81fa9474fef2354ff1fbc898e518a9044640
Wyverald
pushed a commit
that referenced
this pull request
Feb 12, 2024
This is made possible by a refactoring that moves the label parsing of `RepoSpec` attributes coming from module overrides as well as `.bzl` file labels containing repo rules from `BzlmodRepoRuleFunction` into `ModuleFileGlobals`. Also adds a TODO to `BzlmodRepoRuleFunction` to further simplify the logic after the next lockfile version bumps, as old lockfiles are now the only source of non-canonical labels in `RepoSpec`s. Work towards #19301 Closes #21188. PiperOrigin-RevId: 605517195 Change-Id: Id34c81fa9474fef2354ff1fbc898e518a9044640
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
This is made possible by a refactoring that moves the label parsing of `RepoSpec` attributes coming from module overrides as well as `.bzl` file labels containing repo rules from `BzlmodRepoRuleFunction` into `ModuleFileGlobals`. Also adds a TODO to `BzlmodRepoRuleFunction` to further simplify the logic after the next lockfile version bumps, as old lockfiles are now the only source of non-canonical labels in `RepoSpec`s. Work towards #19301 Closes #21188. PiperOrigin-RevId: 605517195 Change-Id: Id34c81fa9474fef2354ff1fbc898e518a9044640 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is made possible by a refactoring that moves the label parsing of
RepoSpecattributes coming from module overrides as well as.bzlfile labels containing repo rules fromBzlmodRepoRuleFunctionintoModuleFileGlobals. Also adds a TODO toBzlmodRepoRuleFunctionto further simplify the logic after the next lockfile version bumps, as old lockfiles are now the only source of non-canonical labels inRepoSpecs.Work towards #19301