Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved PackageLookupFucntion::explainNoBuildFileValue message #21122

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sttsenov
Copy link

@sttsenov sttsenov commented Jan 28, 2024

A possible solution for #16375.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 28, 2024
@fmeum
Copy link
Collaborator

fmeum commented Jan 28, 2024

@sttsenov My linked issue doesn't seem to be related, is there a typo in the number?

@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Jan 29, 2024
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test case for this change?

@sttsenov sttsenov changed the title Improved PackageLookupFucntion::explainNoBuildFileValue message Improved PackageLookupFucntion::explainNoBuildFileValue message Jan 31, 2024
@meteorcloudy meteorcloudy added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-response Awaiting a response from the author team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants