Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.3.0] Fix VS 2022 autodetection #18960

Merged
merged 2 commits into from
Jul 19, 2023
Merged

[6.3.0] Fix VS 2022 autodetection #18960

merged 2 commits into from
Jul 19, 2023

Commits on Jul 17, 2023

  1. Fix VS 2022 autodetection 

    This is the same PR as bazelbuild#18608 but extended by the modification proposed by @meteorcloudy

This should fix bazelbuild#18592

Should also be picked to 6.3.0 -> bazelbuild#18799

Closes bazelbuild#18945.

PiperOrigin-RevId: 548725707
Change-Id: Iff0f972c9fc23491c8070ee2b12ec600a3d1ead9
    @Vertexwahn @iancha1992
    Vertexwahn authored and iancha1992 committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6fd8154 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Set BAZEL_VC for Bazel's integration tests 

    To work around [test failure](https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/16353#018901e5-b0f1-41be-a6f4-e12878711ad3) on bazelbuild#18608. This PR enables Bazel to detect the latest VC build tools installed, but apparently there is a test case which is failing with the new toolchain. Setting --test_env=BAZEL_VC ensures the integrations tests also uses the older VC build tools for now.

PiperOrigin-RevId: 544037250
Change-Id: I4625da17ff2168acbe63813aa7a01e49e0cb459a
    @meteorcloudy @iancha1992
    meteorcloudy authored and iancha1992 committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    ba2ccab View commit details
    Browse the repository at this point in the history