Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.3.0] Add ActionExecutionMetadata as a parameter to `ActionInputPrefetche… #18656

Merged
merged 2 commits into from
Jun 13, 2023
Merged

[6.3.0] Add ActionExecutionMetadata as a parameter to `ActionInputPrefetche… #18656

merged 2 commits into from
Jun 13, 2023

Commits on Jun 13, 2023

  1. Add ActionExecutionMetadata as a parameter to `ActionInputPrefetche… 

    …r#prefetchFiles`.

Due to recent overhual of `prefetchFiles`, the call sites now always have the reference to `ActionExecutionMetadata`, which makes it possible to pass it to `prefetchFiles`.

The reason why we want to access `ActionExecutionMetadata` inside `prefetchFiles` is to associate downloads with actions. For example:

1. When downloading from remote cache, we want to provide action metadata to the RPCs so that remote server can associate them with actions. `actionId` was removed from remote file metadata by f62a8b9 because it is not the right action to associate with for downloads inside this context. We left the action metadata empty for RPCs until this change. bazelbuild#17724 (comment)
2. When building with the bytes, we are able to report download progress to UI. However, `prefetchFiles` is the major way to download when building without the bytes and we can't report download progress on action basis. bazelbuild#17604 added the download report for background downloads, but now, we no longer download toplevel artifacts in background (a5dde12). With this change, we are able to report download progress for each action, either when they download outputs, or prefetch inputs for building without the bytes.

PiperOrigin-RevId: 539635790
Change-Id: Ic9cc1024f5d3560ac46bc462bd549dd81712d92f
    @coeuvre
    coeuvre committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4d56751 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release-6.3.0' into release-6.3.0

    @iancha1992
    iancha1992 authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    428f182 View commit details
    Browse the repository at this point in the history