Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update windows VS detection code to account for new directory #18608

Closed
wants to merge 7 commits into from
Closed

Update windows VS detection code to account for new directory #18608

wants to merge 7 commits into from

Commits on Jun 13, 2023

  1. Update windows VS detection code to account for new directory 

    Windows VS 2022 version 17.6 introduced a new `vspkg` directory
underneath `VC` that is throwing off the toolchain autodetection code.

The checks now got renamed to a more approriate `_is_vs_2017_or_newer`
and takes into account the possible presence of this `vspkg` directory.
    @redsun82
    redsun82 committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    75334d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Update windows VS detection code hard-coded paths with the 2022 version

    @redsun82
    redsun82 committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    0da8c07 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bazelbuild:master' into fix-vs-autodetection

    @redsun82
    redsun82 authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    298bbce View commit details
    Browse the repository at this point in the history

  3. Reorder VS hardcoded paths for autodetection and add 2022 Preview

    @redsun82
    redsun82 committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    de58f41 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. make VS version check more future-proof

    @redsun82
    redsun82 committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a010879 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Merge branch 'master' into fix-vs-autodetection

    @meteorcloudy
    meteorcloudy authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    9afb0ab View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-vs-autodetection

    @meteorcloudy
    meteorcloudy authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    e3a9246 View commit details
    Browse the repository at this point in the history