Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade embedded JDK to version 19/20. #18478

Closed
wants to merge 10 commits into from
Closed

Upgrade embedded JDK to version 19/20. #18478

wants to merge 10 commits into from

Conversation

zhengwei143
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 23, 2023
@zhengwei143 zhengwei143 removed the awaiting-review PR is awaiting review from an assigned reviewer label May 23, 2023
@sgowroji sgowroji added the team-Rules-Java Issues for Java rules label May 23, 2023
@zhengwei143 zhengwei143 added team-Performance Issues for Performance teams and removed team-Rules-Java Issues for Java rules labels May 23, 2023
@zhengwei143
Copy link
Contributor Author

There are currently a few blockers:

  1. Respect rules_java as the source of truth for java toolchains #18423 to be pushed through, then I'll need to handle the merge conflicts as a result of that refactor.
  2. The upgrade of io.netty 4.1.87 -> 4.1.93 should be sent in a separate PR, which will make it compatible with JDK20.
  3. Fix for //src/test/shell/integration:bazel_testjobs_test as a result in the change of behavior in ForkJoinPool in JDK20, likely being handled internally.

@zhengwei143 zhengwei143 mentioned this pull request May 26, 2023
Closed
@zhengwei143 zhengwei143 marked this pull request as draft May 26, 2023 13:40
copybara-service bot pushed a commit that referenced this pull request May 26, 2023
@zhengwei143 @copybara-github
Upgrade io.netty from 4.1.87 -> 4.1.93 to make it compatible with JDK20.
ff1dc3b 
This upgrade is a prerequisite for #18478 so that it is compatible with JDk20.

Closes #18511.

PiperOrigin-RevId: 535610482
Change-Id: If9e86f941fe47da9677a847e467ccaee91afba44
@zhengwei143 zhengwei143 requested a review from coeuvre June 21, 2023 12:53
@zhengwei143 zhengwei143 marked this pull request as ready for review June 21, 2023 12:53
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer and removed team-Performance Issues for Performance teams labels Jun 21, 2023
coeuvre
coeuvre approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coeuvre coeuvre changed the title [WIP] Upgrade embedded JDK to version 20. Upgrade embedded JDK to version 20. Jun 21, 2023
@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 21, 2023
@lberki
Copy link
Contributor

lberki commented Jun 21, 2023

❤️

@zhengwei143 zhengwei143 changed the title Upgrade embedded JDK to version 20. Upgrade embedded JDK to version 19/20. Jun 21, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhengwei143 @lberki @coeuvre @sgowroji