Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module_ctx.extension_metadata #17970

Closed
wants to merge 3 commits into from
Closed

Add module_ctx.extension_metadata #17970

wants to merge 3 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Apr 4, 2023 •
edited
Loading

Fixes #17908

@fmeum fmeum force-pushed the extension-metadata branch 2 times, most recently from 777d201 to 6d5cb9b Compare April 4, 2023 12:38
@fmeum fmeum changed the title Add module_ctx.extension_metadata and module_ctx.use_all_repos Add module_ctx.extension_metadata Apr 4, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 12, 2023

@Wyverald I pushed a new version that supports the "all" syntax. Could you take another look? I would add more tests afterwards.

@fmeum fmeum marked this pull request as ready for review April 12, 2023 10:39
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Apr 12, 2023
Wyverald
Wyverald reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall!

src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionUsage.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionMetadata.java Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionMetadata.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionMetadata.java Outdated Show resolved Hide resolved
@fmeum fmeum force-pushed the extension-metadata branch 2 times, most recently from d7d1c56 to fd7bcba Compare April 17, 2023 14:22
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 17, 2023
@Pavank1992
Copy link
Contributor

Hi @fmeum, As this PR is awaiting to merge, could you please fix the buildkite error? Thanks!

@Pavank1992 Pavank1992 added the awaiting-user-response Awaiting a response from the author label Apr 18, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 18, 2023

Hi @fmeum, As this PR is awaiting to merge, could you please fix the buildkite error? Thanks!

@Pavank1992 I am pretty sure they are not caused by this PR, but I triggered a rerun.

@Pavank1992
Copy link
Contributor

Hi @fmeum, Yes, it needs to be added some comments. I added the Bazel Authors and Apache License, Version 2.0 (the "License") and syncing it. Thanks!

@Pavank1992 Pavank1992 removed the awaiting-user-response Awaiting a response from the author label Apr 18, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 18, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 18, 2023
@Wyverald
Copy link
Member

@bazel-io fork 6.2.0

@bazel-io bazel-io mentioned this pull request Apr 18, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 18, 2023
@Pavank1992 Pavank1992 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 18, 2023
@fmeum fmeum deleted the extension-metadata branch April 18, 2023 13:58
Wyverald pushed a commit that referenced this pull request Apr 21, 2023
@fmeum @Wyverald
Add module_ctx.extension_metadata
673c8c3 
Fixes #17908

Closes #17970.

PiperOrigin-RevId: 525134299
Change-Id: I9088e3f4561c0c27135cfdd1e5be8390ea8da7eb
@Wyverald Wyverald mentioned this pull request Apr 21, 2023
Merged
keertk pushed a commit that referenced this pull request Apr 21, 2023
@Wyverald @fmeum
Add module_ctx.extension_metadata (#18174)
6c61110 
Fixes #17908

Closes #17970.

PiperOrigin-RevId: 525134299
Change-Id: I9088e3f4561c0c27135cfdd1e5be8390ea8da7eb

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@fmeum @fweikert
Add module_ctx.extension_metadata
89931db 
Fixes bazelbuild#17908

Closes bazelbuild#17970.

PiperOrigin-RevId: 525134299
Change-Id: I9088e3f4561c0c27135cfdd1e5be8390ea8da7eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement "Automatic use_repo fixups for module extensions"
5 participants
@fmeum @Pavank1992 @Wyverald @meteorcloudy @bazel-io