Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules_java and remove references to "remote_java_tools_darwin" #17843

Closed
wants to merge 4 commits into from

Conversation

hvadehra
Copy link
Member

@hvadehra hvadehra commented Mar 22, 2023

This is the last step of #17780

This updates rules_java to v5.5.0 for bazel and bazel_tools and cleans up any remaining references to remote_java_tools_darwin, remote_java_tools_test_darwin, and remote_java_tools_darwin_for_testing

@hvadehra hvadehra marked this pull request as ready for review March 22, 2023 13:35
@hvadehra hvadehra requested a review from Wyverald March 22, 2023 13:35
@hvadehra hvadehra added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Mar 22, 2023
@hvadehra hvadehra changed the title Remove references to "remote_java_tools_darwin" Update rules_java and remove references to "remote_java_tools_darwin" Mar 22, 2023
WORKSPACE Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Mar 23, 2023
@meteorcloudy meteorcloudy added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 23, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 24, 2023
@hvadehra hvadehra deleted the java_tools_darwin_cleanup branch March 24, 2023 16:33
meteorcloudy pushed a commit that referenced this pull request Apr 24, 2023
* Separate prebuilt darwin java_tools for x86_64 and arm64

This is step 1 of #17780

Closes #17767.

PiperOrigin-RevId: 517115807
Change-Id: If2bb85a8a15fd126ab52e5738e3d9558da813090

* Update rules_java and remove references to "remote_java_tools_darwin"

This is the last step of #17780

This updates rules_java to v5.5.0 for bazel and bazel_tools and cleans up any remaining references to remote_java_tools_darwin,  remote_java_tools_test_darwin, and remote_java_tools_darwin_for_testing

Closes #17843.

PiperOrigin-RevId: 519059189
Change-Id: Ic04f3a2e5cc12e6b7731f6d8a3551553e172e000

* Update java_tools v12.1

bazelbuild/java_tools#69

Closes #18097.

PiperOrigin-RevId: 526116409
Change-Id: I4f31046d7e5b149c5035b0ede0699d74685a1eb8

---------

Co-authored-by: hvd <hvadehra@gmail.com>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
This is the last step of bazelbuild#17780

This updates rules_java to v5.5.0 for bazel and bazel_tools and cleans up any remaining references to remote_java_tools_darwin,  remote_java_tools_test_darwin, and remote_java_tools_darwin_for_testing

Closes bazelbuild#17843.

PiperOrigin-RevId: 519059189
Change-Id: Ic04f3a2e5cc12e6b7731f6d8a3551553e172e000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants